refactor: hardcode port 8443, remove CUCM_PORT env var

CUCM HTTPS port is always 8443 — not configurable.
Removed CUCM_PORT env var, cucm_port tool parameter, and port
from CucmCredentials interface. Port is now a constant.

Standard env vars: CUCM_HOST, CUCM_USERNAME, CUCM_PASSWORD.
Same as cisco-axl-mcp. Set once in ~/.zshrc, all MCPs use them.

Author: calltelemetry-jason

README.md

@@ -86,16 +86,17 @@ npx @calltelemetry/cisco-ris-mcp
 
 ### Environment Variables
 
-| Variable | Required | Default | Description |
-|----------|----------|---------|-------------|
-| `CUCM_HOST` | Yes | — | CUCM publisher hostname or IP |
-| `CUCM_USERNAME` | Yes | — | CUCM admin username |
-| `CUCM_PASSWORD` | Yes | — | CUCM admin password |
-| `CUCM_PORT` | No | `8443` | CUCM HTTPS port |
-| `RIS_MCP_LOG_LEVEL` | No | `warn` | Log level: `debug`, `info`, `warn`, `error` |
-| `RIS_MCP_TLS_MODE` | No | `permissive` | Set to `strict` to reject self-signed certs |
-
-All credentials can also be passed per-tool-call via `cucm_host`, `cucm_username`, `cucm_password`, `cucm_port` parameters — useful for querying multiple clusters in a single session.
+| Variable | Required | Description |
+|----------|----------|-------------|
+| `CUCM_HOST` | Yes | CUCM publisher hostname or IP |
+| `CUCM_USERNAME` | Yes | CUCM admin username |
+| `CUCM_PASSWORD` | Yes | CUCM admin password |
+| `RIS_MCP_LOG_LEVEL` | No | Log level: `debug`, `info`, `warn`, `error` (default: `warn`) |
+| `RIS_MCP_TLS_MODE` | No | Set to `strict` to reject self-signed certs (default: permissive) |
+
+These are the same env vars used by [`@calltelemetry/cisco-axl-mcp`](https://github.com/calltelemetry/cisco-axl-mcp). Set them once in `~/.zshrc` and all CallTelemetry MCP servers use them. Port is always 8443.
+
+Per-tool-call overrides (`cucm_host`, `cucm_username`, `cucm_password`) are available for querying multiple clusters in a single session.
 
 ### Counter Presets
 

src/lib/credential-resolver.ts

@@ -1,22 +1,25 @@
 import type { CucmCredentials, ToolCredentialOverrides } from "../types/credentials.js";
 
+/** CUCM HTTPS port — always 8443, not configurable */
+export const CUCM_PORT = 8443;
+
 /**
  * Resolve CUCM credentials from per-call overrides or standard env vars.
  *
- * Standard env vars (shared with @calltelemetry/cisco-axl-mcp):
- *   CUCM_HOST, CUCM_USERNAME, CUCM_PASSWORD, CUCM_PORT
+ * Standard env vars (shared across all CallTelemetry MCP servers):
+ *   CUCM_HOST, CUCM_USERNAME, CUCM_PASSWORD
  *
- * Set these once in ~/.zshrc and all CallTelemetry MCP servers use them.
+ * Set these once in ~/.zshrc and all MCP servers use them.
+ * Port is always 8443 — not configurable.
  */
 export function resolveCredentials(overrides?: ToolCredentialOverrides): CucmCredentials {
   const host = overrides?.cucm_host || process.env.CUCM_HOST;
   const username = overrides?.cucm_username || process.env.CUCM_USERNAME;
   const password = overrides?.cucm_password || process.env.CUCM_PASSWORD;
-  const port = overrides?.cucm_port || Number(process.env.CUCM_PORT) || 8443;
 
   if (!host) throw new Error("CUCM host required. Set CUCM_HOST or pass cucm_host parameter.");
   if (!username) throw new Error("CUCM username required. Set CUCM_USERNAME or pass cucm_username parameter.");
   if (!password) throw new Error("CUCM password required. Set CUCM_PASSWORD or pass cucm_password parameter.");
 
-  return { host, username, password, port };
+  return { host, username, password };
 }

src/services/perfmon/index.ts

@@ -2,6 +2,7 @@ import { escapeXml, fetchServiceabilitySoap, toArray } from "../../lib/soap-clie
 import { withRateLimit } from "../../lib/rate-limiter.js";
 import { log } from "../../lib/logger.js";
 import type { CucmCredentials } from "../../types/credentials.js";
+import { CUCM_PORT } from "../../lib/credential-resolver.js";
 import type { PerfmonCounterValue, PerfmonCounterInfo, MonitorJob, TimestampedSample } from "../../types/perfmon-types.js";
 
 const PERFMON_PATH = "/perfmonservice2/services/PerfmonService";
@@ -92,7 +93,7 @@ export async function perfmonCollectCounterData(
   const envelope = buildCollectCounterDataEnvelope(perfmonHost, object);
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonCollectCounterData", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonCollectCounterData", envelope, timeoutMs ?? 30_000)
   );
 
   const resp = body.perfmonCollectCounterDataResponse as Record<string, unknown> | undefined;
@@ -114,7 +115,7 @@ export async function perfmonListCounter(
   const envelope = buildListCounterEnvelope(perfmonHost);
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonListCounter", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonListCounter", envelope, timeoutMs ?? 30_000)
   );
 
   const resp = body.perfmonListCounterResponse as Record<string, unknown> | undefined;
@@ -143,7 +144,7 @@ export async function perfmonListInstance(
   const envelope = buildListInstanceEnvelope(perfmonHost, object);
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonListInstance", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonListInstance", envelope, timeoutMs ?? 30_000)
   );
 
   const resp = body.perfmonListInstanceResponse as Record<string, unknown> | undefined;
@@ -159,7 +160,7 @@ export async function perfmonOpenSession(creds: CucmCredentials, timeoutMs?: num
   const envelope = buildOpenSessionEnvelope();
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonOpenSession", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonOpenSession", envelope, timeoutMs ?? 30_000)
   );
 
   const resp = body.perfmonOpenSessionResponse as Record<string, unknown> | undefined;
@@ -176,7 +177,7 @@ export async function perfmonAddCounter(
 ): Promise<void> {
   const envelope = buildAddCounterEnvelope(sessionHandle, counters);
   await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonAddCounter", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonAddCounter", envelope, timeoutMs ?? 30_000)
   );
 }
 
@@ -188,7 +189,7 @@ export async function perfmonCollectSessionData(
   const envelope = buildCollectSessionDataEnvelope(sessionHandle);
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonCollectSessionData", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonCollectSessionData", envelope, timeoutMs ?? 30_000)
   );
 
   const resp = body.perfmonCollectSessionDataResponse as Record<string, unknown> | undefined;
@@ -209,7 +210,7 @@ export async function perfmonCloseSession(
 ): Promise<void> {
   const envelope = buildCloseSessionEnvelope(sessionHandle);
   await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, PERFMON_PATH, "perfmonCloseSession", envelope, timeoutMs ?? 30_000)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, PERFMON_PATH, "perfmonCloseSession", envelope, timeoutMs ?? 30_000)
   );
 }
 

src/services/ris/index.ts

@@ -2,6 +2,7 @@ import { escapeXml, fetchServiceabilitySoap, toArray } from "../../lib/soap-clie
 import { withRateLimit } from "../../lib/rate-limiter.js";
 import { log } from "../../lib/logger.js";
 import type { CucmCredentials } from "../../types/credentials.js";
+import { CUCM_PORT } from "../../lib/credential-resolver.js";
 import type { RisDevice, RisNode, RisDeviceResult, CtiItem, CtiResult, LineStatus } from "../../types/ris-types.js";
 
 const RIS_PATH = "/realtimeservice2/services/RISService70";
@@ -138,7 +139,7 @@ export async function selectCmDevice(
   const timeout = args.timeoutMs ?? 60_000;
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, RIS_PATH, "selectCmDevice", envelope, timeout)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, RIS_PATH, "selectCmDevice", envelope, timeout)
   );
 
   const resp = body.selectCmDeviceResponse as Record<string, unknown> | undefined;
@@ -236,7 +237,7 @@ export async function selectCtiItem(
   const timeout = args.timeoutMs ?? 30_000;
 
   const body = await withRateLimit(creds.host, () =>
-    fetchServiceabilitySoap(creds.host, creds.port, creds, RIS_PATH, "selectCtiItem", envelope, timeout)
+    fetchServiceabilitySoap(creds.host, CUCM_PORT, creds, RIS_PATH, "selectCtiItem", envelope, timeout)
   );
 
   const resp = body.selectCtiItemResponse as Record<string, unknown> | undefined;

src/tools/counter-tools.ts

@@ -16,7 +16,6 @@ const credentialProperties = {
   cucm_host: { type: "string", description: "CUCM hostname (overrides CUCM_HOST env)" },
   cucm_username: { type: "string", description: "CUCM username (overrides CUCM_USERNAME env)" },
   cucm_password: { type: "string", description: "CUCM password (overrides CUCM_PASSWORD env)" },
-  cucm_port: { type: "number", description: "CUCM port (default 8443)" },
 };
 
 export const counterTools: ToolDefinition[] = [

src/tools/device-tools.ts

@@ -9,7 +9,6 @@ const credentialProperties = {
   cucm_host: { type: "string", description: "CUCM hostname (overrides CUCM_HOST env)" },
   cucm_username: { type: "string", description: "CUCM username (overrides CUCM_USERNAME env)" },
   cucm_password: { type: "string", description: "CUCM password (overrides CUCM_PASSWORD env)" },
-  cucm_port: { type: "number", description: "CUCM port (default 8443)" },
 };
 
 export const deviceTools: ToolDefinition[] = [

src/tools/insight-tools.ts

@@ -10,7 +10,6 @@ const credentialProperties = {
   cucm_host: { type: "string", description: "CUCM hostname (overrides CUCM_HOST env)" },
   cucm_username: { type: "string", description: "CUCM username (overrides CUCM_USERNAME env)" },
   cucm_password: { type: "string", description: "CUCM password (overrides CUCM_PASSWORD env)" },
-  cucm_port: { type: "number", description: "CUCM port (default 8443)" },
 };
 
 export const insightTools: ToolDefinition[] = [

src/types/credentials.ts

@@ -2,12 +2,10 @@ export interface CucmCredentials {
   host: string;
   username: string;
   password: string;
-  port: number;
 }
 
 export interface ToolCredentialOverrides {
   cucm_host?: string;
   cucm_username?: string;
   cucm_password?: string;
-  cucm_port?: number;
 }

test/credential-resolver.test.ts

@@ -1,15 +1,13 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import { resolveCredentials } from "../src/lib/credential-resolver.js";
+import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { resolveCredentials, CUCM_PORT } from "../src/lib/credential-resolver.js";
 
 describe("resolveCredentials", () => {
   const originalEnv = { ...process.env };
 
   beforeEach(() => {
-    // Clear all CUCM env vars
     delete process.env.CUCM_HOST;
     delete process.env.CUCM_USERNAME;
     delete process.env.CUCM_PASSWORD;
-    delete process.env.CUCM_PORT;
   });
 
   afterEach(() => {
@@ -25,7 +23,6 @@ describe("resolveCredentials", () => {
     expect(creds.host).toBe("cucm1.example.com");
     expect(creds.username).toBe("admin");
     expect(creds.password).toBe("secret");
-    expect(creds.port).toBe(8443);
   });
 
   it("per-call overrides take precedence over env vars", () => {
@@ -37,12 +34,10 @@ describe("resolveCredentials", () => {
       cucm_host: "override-host",
       cucm_username: "override-user",
       cucm_password: "override-pass",
-      cucm_port: 9443,
     });
     expect(creds.host).toBe("override-host");
     expect(creds.username).toBe("override-user");
     expect(creds.password).toBe("override-pass");
-    expect(creds.port).toBe(9443);
   });
 
   it("throws with helpful message when host is missing", () => {
@@ -66,24 +61,10 @@ describe("resolveCredentials", () => {
 
     expect(() => resolveCredentials()).toThrow(/CUCM password required/);
   });
+});
 
-  it("default port is 8443", () => {
-    process.env.CUCM_HOST = "host";
-    process.env.CUCM_USERNAME = "admin";
-    process.env.CUCM_PASSWORD = "secret";
-
-    const creds = resolveCredentials();
-    expect(creds.port).toBe(8443);
-  });
-
-  it("CUCM_PORT env overrides default port", () => {
-    process.env.CUCM_HOST = "host";
-    process.env.CUCM_USERNAME = "admin";
-    process.env.CUCM_PASSWORD = "secret";
-    process.env.CUCM_PORT = "9999";
-
-    const creds = resolveCredentials();
-    expect(creds.port).toBe(9999);
+describe("CUCM_PORT constant", () => {
+  it("is always 8443", () => {
+    expect(CUCM_PORT).toBe(8443);
   });
-
 });