Resolve remaining lint warnings

Author: callumalpass

build-css.mjs

@@ -38,7 +38,8 @@ const CSS_FILES = [
     'styles/settings-view.css',      // SettingsView component with proper BEM scoping
     'styles/webhook-settings.css',   // Webhook settings UI with proper BEM scoping
     'styles/status-bar.css',         // StatusBar component with proper BEM scoping
-    'styles/bases-views.css'         // Bases integration views (list and kanban)
+    'styles/bases-views.css',        // Bases integration views (list and kanban)
+    'styles/static-style-utilities.css' // Static style utility classes migrated from inline styles
 ];
 
 const MAIN_CSS_TEMPLATE = `/* TaskNotes Plugin Styles */
@@ -119,4 +120,4 @@ function buildCSS() {
 }
 
 // Run the build
-buildCSS();
+buildCSS();

src/api/SystemController.ts

@@ -4,7 +4,7 @@ import { NaturalLanguageParser } from "../services/NaturalLanguageParser";
 import { TaskCreationData } from "../types";
 import { TaskService } from "../services/TaskService";
 import TaskNotesPlugin from "../main";
- 
+
 import { generateOpenAPISpec, Get, Post } from "../utils/OpenAPIDecorators";
 
 export class SystemController extends BaseController {
@@ -31,7 +31,7 @@ export class SystemController extends BaseController {
 			} else if ("path" in adapter && typeof adapter.path === "string") {
 				vaultPath = adapter.path;
 			}
-		} catch (error) {
+		} catch {
 			// Silently fail if vault path isn't accessible
 		}
 

src/api/TasksController.ts

@@ -7,7 +7,7 @@ import { FilterService } from "../services/FilterService";
 import { TaskManager } from "../utils/TaskManager";
 import { TaskStatsService } from "../services/TaskStatsService";
 import TaskNotesPlugin from "../main";
- 
+
 import { Get, Post, Put, Delete } from "../utils/OpenAPIDecorators";
 
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
@@ -108,7 +108,7 @@ export class TasksController extends BaseController {
 				} else if ("path" in adapter && typeof adapter.path === "string") {
 					vaultPath = adapter.path;
 				}
-			} catch (error) {
+			} catch {
 				// Silently fail if vault path isn't accessible
 			}
 
@@ -351,7 +351,7 @@ export class TasksController extends BaseController {
 				} else if ("path" in adapter && typeof adapter.path === "string") {
 					vaultPath = adapter.path;
 				}
-			} catch (error) {
+			} catch {
 				// Silently fail if vault path isn't accessible
 			}
 
@@ -403,5 +403,4 @@ export class TasksController extends BaseController {
 			this.sendResponse(res, 500, this.errorResponse(error.message));
 		}
 	}
-
 }

src/api/WebhookController.ts

@@ -1,10 +1,10 @@
- 
 import { IncomingMessage, ServerResponse } from "http";
+import { requestUrl } from "obsidian";
 import { BaseController } from "./BaseController";
 import { WebhookConfig, WebhookDelivery, WebhookEvent, WebhookPayload } from "../types";
 import { createHash, createHmac } from "crypto";
 import TaskNotesPlugin from "../main";
- 
+
 import { Get, Post, Delete } from "../utils/OpenAPIDecorators";
 
 export class WebhookController extends BaseController {
@@ -172,7 +172,7 @@ export class WebhookController extends BaseController {
 			} else if ("path" in adapter && typeof adapter.path === "string") {
 				vaultPath = adapter.path;
 			}
-		} catch (error) {
+		} catch {
 			// Silently fail if vault path isn't accessible
 		}
 
@@ -243,20 +243,22 @@ export class WebhookController extends BaseController {
 				headers["X-TaskNotes-Delivery-ID"] = delivery.id;
 			}
 
-			const response = await fetch(webhook.url, {
+			const response = await requestUrl({
+				url: webhook.url,
 				method: "POST",
 				headers,
 				body: JSON.stringify(delivery.payload),
+				throw: false,
 			});
 
 			delivery.responseStatus = response.status;
 
-			if (response.ok) {
+			if (response.status >= 200 && response.status < 300) {
 				delivery.status = "success";
 				webhook.successCount++;
 				webhook.lastTriggered = new Date().toISOString();
 			} else {
-				throw new Error(`HTTP ${response.status}: ${response.statusText}`);
+				throw new Error(`HTTP ${response.status}: ${response.text}`);
 			}
 		} catch (error: any) {
 			delivery.error = error.message;
@@ -333,8 +335,6 @@ export class WebhookController extends BaseController {
 		payload: WebhookPayload
 	): Promise<any> {
 		try {
-			console.log(`🔧 Applying transformation: ${transformFile}`);
-
 			if (transformFile.endsWith(".js")) {
 				return await this.applyJSTransformation(transformFile, payload);
 			} else if (transformFile.endsWith(".json")) {
@@ -357,15 +357,10 @@ export class WebhookController extends BaseController {
 		payload: WebhookPayload
 	): Promise<any> {
 		try {
-			console.log(`📂 Reading transform file: ${transformFile}`);
-
 			// Read transformation file from vault
 			let transformCode: string;
 			try {
 				transformCode = await this.plugin.app.vault.adapter.read(transformFile);
-				console.log(
-					`✅ Transform file loaded successfully (${transformCode.length} characters)`
-				);
 			} catch (readError: any) {
 				throw new Error(
 					`Failed to read transform file '${transformFile}': ${readError.message}. Please check the file path and ensure it exists in your vault.`
@@ -386,8 +381,6 @@ export class WebhookController extends BaseController {
 				);
 			}
 
-			console.log(`🔧 Executing transform function for event: ${payload.event}`);
-
 			// Create a safe execution context
 			// User-authored transform files are an explicit trusted scripting feature.
 			// eslint-disable-next-line @typescript-eslint/no-implied-eval
@@ -405,7 +398,6 @@ export class WebhookController extends BaseController {
 			);
 
 			const result = transform(payload);
-			console.log(`✅ Transform completed successfully for ${transformFile}`);
 			return result;
 		} catch (error: any) {
 			console.error(`❌ JS transformation error for '${transformFile}':`, error.message);
@@ -418,15 +410,10 @@ export class WebhookController extends BaseController {
 		payload: WebhookPayload
 	): Promise<any> {
 		try {
-			console.log(`📂 Reading JSON template file: ${transformFile}`);
-
 			// Read template file from vault
 			let templateContent: string;
 			try {
 				templateContent = await this.plugin.app.vault.adapter.read(transformFile);
-				console.log(
-					`✅ JSON template file loaded successfully (${templateContent.length} characters)`
-				);
 			} catch (readError: any) {
 				throw new Error(
 					`Failed to read template file '${transformFile}': ${readError.message}. Please check the file path and ensure it exists in your vault.`
@@ -450,8 +437,6 @@ export class WebhookController extends BaseController {
 				);
 			}
 
-			console.log(`🔧 Applying JSON template for event: ${payload.event}`);
-
 			// Get template for this event or use default
 			const template = templates[payload.event] || templates.default;
 			if (!template) {
@@ -463,7 +448,6 @@ export class WebhookController extends BaseController {
 
 			// Apply template variable substitution
 			const result = this.interpolateTemplate(template, payload);
-			console.log(`✅ JSON template applied successfully for ${transformFile}`);
 			return result;
 		} catch (error: any) {
 			console.error(`❌ JSON transformation error for '${transformFile}':`, error.message);

src/api/loadAPIEndpoints.ts

@@ -1,3 +1,5 @@
+import { requestUrl } from "obsidian";
+
 async function loadAPIEndpoints(container: HTMLElement, apiPort = 8080): Promise<void> {
 	// Show loading message first
 	const loadingEl = container.createEl("p", {
@@ -6,19 +8,16 @@ async function loadAPIEndpoints(container: HTMLElement, apiPort = 8080): Promise
 	});
 
 	try {
-		 
-		console.log(`Fetching API documentation from http://localhost:${apiPort}/api/docs`);
-		const response = await fetch(`http://localhost:${apiPort}/api/docs`);
-		 
-		console.log("API docs response:", response.status, response.statusText);
+		const response = await requestUrl({
+			url: `http://localhost:${apiPort}/api/docs`,
+			throw: false,
+		});
 
-		if (!response.ok) {
-			throw new Error(`API unavailable (${response.status}: ${response.statusText})`);
+		if (response.status < 200 || response.status >= 300) {
+			throw new Error(`API unavailable (${response.status})`);
 		}
 
-		const openApiSpec = await response.json();
-		 
-		console.log("OpenAPI spec loaded:", openApiSpec);
+		const openApiSpec = response.json;
 
 		// Remove loading message
 		loadingEl.remove();

src/bases/BasesDataAdapter.ts

@@ -1,5 +1,12 @@
 import { BasesDataItem } from "./helpers";
-import type { BasesEntry, BasesEntryGroup, BasesPropertyId, BasesView, TFile, Value } from "obsidian";
+import type {
+	BasesEntry,
+	BasesEntryGroup,
+	BasesPropertyId,
+	BasesView,
+	TFile,
+	Value,
+} from "obsidian";
 
 type BasesViewDataSource = Pick<BasesView, "config" | "data">;
 
@@ -120,7 +127,6 @@ export class BasesDataAdapter {
 		}
 	}
 
-
 	/**
 	 * Convert Bases Value object to native JavaScript value.
 	 * Handles: PrimitiveValue, ListValue, DateValue, FileValue, NullValue, etc.
@@ -137,11 +143,12 @@ export class BasesDataAdapter {
 		}
 
 		// ListValue
-		const getListItem = typeof basesValue.get === "function"
-			? basesValue.get.bind(basesValue)
-			: typeof basesValue.at === "function"
-				? basesValue.at.bind(basesValue)
-				: null;
+		const getListItem =
+			typeof basesValue.get === "function"
+				? basesValue.get.bind(basesValue)
+				: typeof basesValue.at === "function"
+					? basesValue.at.bind(basesValue)
+					: null;
 		if (typeof basesValue.length === "function" && getListItem) {
 			const len = basesValue.length();
 			const result = [];
@@ -220,8 +227,8 @@ export class BasesDataAdapter {
 		// Format Date objects as YYYY-MM-DD (date only, no time)
 		if (actualValue instanceof Date) {
 			const year = actualValue.getFullYear();
-			const month = String(actualValue.getMonth() + 1).padStart(2, '0');
-			const day = String(actualValue.getDate()).padStart(2, '0');
+			const month = String(actualValue.getMonth() + 1).padStart(2, "0");
+			const day = String(actualValue.getDate()).padStart(2, "0");
 			return `${year}-${month}-${day}`;
 		}
 
@@ -289,7 +296,7 @@ export class BasesDataAdapter {
 		try {
 			const value = basesEntry.getValue(propertyId as BasesPropertyId);
 			return this.convertValueToNative(value);
-		} catch (e) {
+		} catch {
 			return null;
 		}
 	}