Merge feature/factor-out-indexdClient changes (#190)

* factor out indexd client

* updates

* add tests to improve coverage

* bump go mod file

* fix up mod file

* passing monorepo test

* cleanup gh actions errs

* gh action

* add tests

* github action

* move transfer-ref test into integration tests

* add mock server to test

* skip all integration tests

* add git config load/store. cleanup packages

* update logging

* fix go mod file

* update git-drs to reflect data-lcient changes

* fix concurrent transfers bug

* add back in support for the rest of the custom configs

* refactor drs init test

* bump data-client dep

* update deps

* adjust clone test for renaming

* coverage

* spelling

* coverage

Author: matthewpeterkort

.github/workflows/pr-checks.yaml

@@ -71,4 +71,4 @@ jobs:
         go-version-file: go.mod
 
     - name: Run tests
-      run: go test -v -race $(go list ./... | grep -v 'tests/integration/calypr' | grep -v 'client/indexd/tests')
+      run: go test -v -race $(go list ./... | grep -v 'tests/integration' | grep -v 'client/indexd/tests')

.github/workflows/test.yaml

@@ -28,9 +28,9 @@ jobs:
         find . -name "*.sh" | xargs ls -l
         find . -name "*.out" | xargs ls -l
 
-    - name: Check uploaded coverage files
-      run: |
-        tests/scripts/coverage/assert-coverage-timestamp.sh 
+    #- name: Check uploaded coverage files
+    #  run: |
+    #    tests/scripts/coverage/assert-coverage-timestamp.sh 
 
     - name: Upload coverage reports as artifact
       uses: actions/upload-artifact@v4

client/anvil/anvil_client.go

@@ -10,8 +10,8 @@ import (
 	"time"
 
 	"github.com/bytedance/sonic"
-	"github.com/calypr/git-drs/drs"
-	"github.com/calypr/git-drs/drs/hash"
+	drs "github.com/calypr/data-client/indexd/drs"
+	hash "github.com/calypr/data-client/indexd/hash"
 	"golang.org/x/oauth2/google"
 )
 
@@ -20,7 +20,7 @@ type AnvilClient struct {
 	SConfig  sonic.API
 }
 
-func (an *AnvilClient) GetObject(objectID string) (*drs.DRSObject, error) {
+func (an *AnvilClient) GetObject(ctx context.Context, objectID string) (*drs.DRSObject, error) {
 	// get auth token
 	token, err := GetAuthToken()
 	if err != nil {

client/anvil/remote.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"log/slog"
 
+	"github.com/calypr/data-client/g3client"
 	"github.com/calypr/git-drs/client"
 )
 
@@ -30,7 +31,7 @@ func (s AnvilRemote) GetBucketName() string {
 	return ""
 }
 
-func (s AnvilRemote) GetClient(params map[string]string, logger *slog.Logger) (client.DRSClient, error) {
+func (s AnvilRemote) GetClient(remoteName string, logger *slog.Logger, opts ...g3client.Option) (client.DRSClient, error) {
 	return nil, fmt.Errorf(("AnVIL Client needs to be implemented"))
 	// return NewAnvilClient(s, logger)
 }

client/anvil/remote_test.go

@@ -31,7 +31,7 @@ func TestAnvilRemoteAccessors(t *testing.T) {
 func TestAnvilRemoteGetClientNotImplemented(t *testing.T) {
 	remote := AnvilRemote{}
 	logger := slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{Level: slog.LevelDebug}))
-	client, err := remote.GetClient(map[string]string{}, logger)
+	client, err := remote.GetClient("", logger)
 	if err == nil {
 		t.Fatalf("expected error")
 	}