chore/monorepos#244
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21db2c2e88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| git drs remote add gen3 "$PROFILE" "$PROGRAM/$PROJECT" --cred "$CREDENTIALS_PATH" | ||
| git lfs pull origin main | ||
| git drs remote add gen3 origin "$PROGRAM/$PROJECT" --cred "$CREDENTIALS_PATH" | ||
| git drs pull origin main |
There was a problem hiding this comment.
Drop the branch argument from git drs pull
When --clone is used, this always exits before hydration because git drs pull does not accept the branch argument carried over from git lfs pull; I checked cmd/pull/main.go, which rejects more than one arg, and docs/commands.md documents git drs pull as hydration-only. Since this script has set -e, git drs pull origin main aborts the clone validation path instead of hydrating the pointers.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@matthewpeterkort Can you confirm this behavior?
Description
This PR refactors the monorepos test infrastructure to remove Git LFS dependencies and transition to using
git-drs(Data Repository Service) for managing large files. The changes simplify the test setup and execution by eliminating Git LFS installation requirements and replacing Git LFS commands with theirgit-drsequivalents.Changes
tests/monorepos/Makefilegenerate-large-fixtures-runto.PHONYtarget listgenerate-fixtures-runecho message to clarify it generates a "small set of fixtures"generate-large-fixtures-runtarget that generates a large dataset (25 TCGA projects with 100 files each in 3 subdirectories)tests/monorepos/run-test.shcalypr_admin projects lstocalypr-cli auth --allfor project verificationGIT_LFS_SKIP_SMUDGE=1flag to initial git clonegit lfs pullwithgit drs pullgit lfs track→git drs trackgit lfs ls-files→git drs ls-filesgit lfs push --dry-runcalls removed (no longer needed)git lfs statuscalls removed (no longer needed)git drs remote addsyntax from"$PROFILE" "$PROGRAM/$PROJECT"toorigin "$PROGRAM/$PROJECT"--enable-data-client-logsflag togit drs initgit config --local --get drs.enable-data-client-logscheckhead -n 1to file search to handle multiple matchesbreakstatement to enable full test execution across all directories (instead of just testing one directory)Why
These changes:
generate-large-fixtures-runtarget for comprehensive testing scenariosTesting
The refactored test suite should now:
git-drsType of change: