Skip to content

Commit 05334c5

Browse files
Copilotcameri
andauthored
fix(ci): address reviewer feedback on checks.yml security and correctness
Agent-Logs-Url: https://github.com/cameri/nostream/sessions/5e3c60f2-1798-47a5-b25a-45c990bfb6bd Co-authored-by: cameri <378886+cameri@users.noreply.github.com>
1 parent c65405e commit 05334c5

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

.github/workflows/checks.yml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,14 @@ jobs:
1616
name: Detect changed paths
1717
runs-on: ubuntu-latest
1818
permissions:
19+
contents: read
1920
pull-requests: read
2021
outputs:
2122
src: ${{ steps.filter.outputs.src }}
2223
steps:
2324
- uses: actions/checkout@v4
25+
with:
26+
fetch-depth: 0
2427
- id: filter
2528
uses: dorny/paths-filter@v3
2629
with:
@@ -100,10 +103,9 @@ jobs:
100103
- lint
101104
- build-check
102105
if: |
103-
always() &&
104106
needs.changes.outputs.src == 'true' &&
105-
needs.lint.result != 'failure' &&
106-
needs.build-check.result != 'failure'
107+
needs.lint.result == 'success' &&
108+
needs.build-check.result == 'success'
107109
steps:
108110
- name: Checkout
109111
uses: actions/checkout@v4
@@ -125,7 +127,7 @@ jobs:
125127
name: unit-coverage-lcov
126128
path: .coverage/unit/lcov.info
127129
- name: Coveralls
128-
uses: coverallsapp/github-action@master
130+
uses: coverallsapp/github-action@v2.3.6
129131
if: ${{ always() }}
130132
with:
131133
path-to-lcov: ./.coverage/unit/lcov.info
@@ -141,10 +143,9 @@ jobs:
141143
- lint
142144
- build-check
143145
if: |
144-
always() &&
145146
needs.changes.outputs.src == 'true' &&
146-
needs.lint.result != 'failure' &&
147-
needs.build-check.result != 'failure'
147+
needs.lint.result == 'success' &&
148+
needs.build-check.result == 'success'
148149
steps:
149150
- name: Checkout
150151
uses: actions/checkout@v4
@@ -163,7 +164,7 @@ jobs:
163164
- name: Run coverage for integration tests
164165
run: npm run docker:cover:integration
165166
- name: Coveralls
166-
uses: coverallsapp/github-action@master
167+
uses: coverallsapp/github-action@v2.3.6
167168
if: ${{ always() }}
168169
with:
169170
path-to-lcov: .coverage/integration/lcov.info
@@ -187,7 +188,7 @@ jobs:
187188
if: ${{ always() }}
188189
steps:
189190
- name: Coveralls Finished
190-
uses: coverallsapp/github-action@master
191+
uses: coverallsapp/github-action@v2.3.6
191192
if: |
192193
needs.test-units-and-cover.result != 'skipped' ||
193194
needs.test-integrations-and-cover.result != 'skipped'

0 commit comments

Comments
 (0)