Skip to content

Commit 704cba1

Browse files
fix(ci): enable automatic Release PR creation in changesets workflow (#543)
* fix(ci): enable changeset commits for Release PR creation - Set 'commit: true' in .changeset/config.json so changesets/action@v1 can commit version changes - Add commitMessage template to match release prefix - Add 'title' option to changesets/action for consistent Release PR naming - Without these fixes, Release PR was not being created despite 14 pending changesets This enables the full workflow: 1. changesets.yml detects changesets and creates 'Version Packages' PR 2. PR merges → publish step runs (changeset:tag) 3. GitHub release created → release.yml builds Docker image Also fix: format if/else blocks in rate-limiter test to meet linting standards * fix(ci): add required permissions to changesets workflow - Add 'contents: write' for committing version changes - Add 'pull-requests: write' for creating Release PRs These permissions are required for changesets/action to properly create and manage the Release PR workflow. * chore: add empty changeset for CI workflow fixes --------- Co-authored-by: Ricardo Cabral <me@ricardocabral.io>
1 parent a89a95e commit 704cba1

4 files changed

Lines changed: 14 additions & 4 deletions

File tree

.changeset/config.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
{
22
"$schema": "https://unpkg.com/@changesets/config@3.1.4/schema.json",
33
"changelog": "@changesets/cli/changelog",
4-
"commit": false,
4+
"commit": true,
55
"fixed": [],
66
"linked": [],
77
"access": "restricted",
88
"baseBranch": "main",
99
"updateInternalDependencies": "patch",
10-
"ignore": []
10+
"ignore": [],
11+
"commitMessage": "chore(release): version packages\n\n[skip ci]"
1112
}

.changeset/tired-dots-cover.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

.github/workflows/changesets.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ jobs:
1212
name: Release
1313
runs-on: ubuntu-latest
1414
environment: release
15+
permissions:
16+
contents: write
17+
pull-requests: write
1518
steps:
1619
- name: Checkout
1720
uses: actions/checkout@v3
@@ -32,5 +35,6 @@ jobs:
3235
version: npm run changeset:version
3336
publish: npm run changeset:tag
3437
createGithubReleases: true
38+
title: "chore(release): version packages"
3539
env:
3640
GITHUB_TOKEN: ${{ secrets.RELEASE_PAT }}

test/integration/features/rate-limiter/rate-limiter.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,11 @@ When(/(\w+) sends a text_note event expecting to be rate limited/, async functio
4343

4444
await new Promise<void>((resolve, reject) => {
4545
ws.send(JSON.stringify(['EVENT', event]), (err) => {
46-
if (err) reject(err)
47-
else resolve()
46+
if (err) {
47+
reject(err)
48+
} else {
49+
resolve()
50+
}
4851
})
4952
})
5053

0 commit comments

Comments
 (0)