Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .eslintignore

This file was deleted.

35 changes: 0 additions & 35 deletions .eslintrc.js

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
cache: npm
- name: Install package dependencies
run: npm ci
- name: Run ESLint
- name: Run Biome
run: npm run lint
build-check:
name: Build check
Expand All @@ -54,7 +54,7 @@ jobs:
cache: npm
- name: Install package dependencies
run: npm ci
- name: Run ESLint
- name: Run build check
run: npm run build:check
test-units-and-cover:
name: Unit Tests And Coverage
Expand Down
11 changes: 10 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Run dead code and dependency analysis before opening a pull request:
npm run knip
```

`npm run lint` now runs Knip first, then ESLint.
`npm run lint` now runs Knip first, then Biome.
Comment thread
Priyanshubhartistm marked this conversation as resolved.
Outdated

## Pull Request Process

Expand All @@ -24,3 +24,12 @@ npm run knip
Pull Request would represent. The versioning scheme we use is [SemVer](http://semver.org/).
3. You may merge the Pull Request in once you have the sign-off of two other developers, or if you
do not have permission to do that, you may request the second reviewer to merge it for you.

## Code Quality

Run Biome checks before opening a pull request:

```
npm run lint
npm run format:check
```
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,17 @@ Start:

## Tests

### Linting and formatting (Biome)

Run code quality checks with Biome:

```
npm run lint
npm run lint:fix
npm run format
npm run format:check
```

### Unit tests

Open a terminal and change to the project's directory:
Expand Down
37 changes: 37 additions & 0 deletions biome.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"$schema": "https://biomejs.dev/schemas/2.4.11/schema.json",
"vcs": { "enabled": true, "clientKind": "git", "useIgnoreFile": true },
"files": {
"ignoreUnknown": false,
"includes": [
"**",
"!**/node_modules/**",
"!**/dist/**",
"!**/.test-reports/**",
"!**/.coverage/**",
"!**/.nostr/**",
"!**/tslint.json"
]
},
"formatter": {
"enabled": true,
"indentStyle": "space",
"lineWidth": 120
},
"linter": {
"enabled": true,
"rules": {
"recommended": false,
"correctness": { "noUnusedVariables": "warn" },
Comment thread
Priyanshubhartistm marked this conversation as resolved.
Outdated
"style": { "useBlockStatements": "warn" },
"suspicious": { "noExplicitAny": "off" }
}
},
"javascript": {
"formatter": {
"quoteStyle": "single",
"semicolons": "asNeeded",
"trailingCommas": "all"
}
}
}
Loading
Loading