Skip to content

feat: support uppercase tag filters (#A-Z) in filter schema #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameri merged 6 commits into from
Apr 21, 2026
Merged

feat: support uppercase tag filters (#A-Z) in filter schema #548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37726d8
feat: support uppercase tag filters (#A-Z) in filter schema
CKodidela Apr 20, 2026
734eda7
Merge branch 'main' into feat/uppercase-tag-filters
CKodidela Apr 20, 2026
99365d6
refactor: reuse isGenericTagQuery in filter schema validation
CKodidela Apr 20, 2026
c728766
chore: add changeset for uppercase tag filter support
CKodidela Apr 20, 2026
1457a6b
docs: add tag filter scope section and NIP-22 comment threading test
CKodidela Apr 20, 2026
344f64e
Merge branch 'main' into feat/uppercase-tag-filters
cameri Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/schemas/filter-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const filterSchema = z
.catchall(z.array(z.string().min(1).max(1024)))
.superRefine((data, ctx) => {
for (const key of Object.keys(data)) {
if (!knownFilterKeys.has(key) && !/^#[a-z]$/.test(key)) {
if (!knownFilterKeys.has(key) && !/^#[a-zA-Z]$/.test(key)) {
ctx.addIssue({
Comment thread
CKodidela marked this conversation as resolved.
code: z.ZodIssueCode.custom,
message: `Unknown key: ${key}`,
Expand Down
13 changes: 13 additions & 0 deletions test/unit/schemas/filter-schema.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,19 @@ describe('NIP-01', () => {
}
})

it('accepts uppercase tag filters (#A-Z)', () => {
const filterWithUppercase = {
...filter,
'#I': ['identifier1', 'identifier2'],
'#K': ['1111'],
'#E': ['aa', 'bb'],
'#A': ['10000:pubkey:dtag'],
}
const result = validateSchema(filterSchema)(filterWithUppercase)
expect(result.error).to.be.undefined
expect(result.value).to.deep.equal(filterWithUppercase)
})

it('returns same filter if filter is valid', () => {
const result = validateSchema(filterSchema)(filter)

Expand Down
Loading