Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

feat: add litmus_auth interface spec#295

Merged
james-garner-canonical merged 12 commits into
mainfrom
TAP-700
Aug 29, 2025
Merged

feat: add litmus_auth interface spec#295
james-garner-canonical merged 12 commits into
mainfrom
TAP-700

Conversation

@michaeldmitry
Copy link
Copy Markdown
Contributor

Adds an interface specification and schema for a new litmus_auth interface, used by Litmus auth and backend to communicate to each other their gRPC server endpoints.

Comment thread interfaces/litmus_auth/v0/README.md Outdated
Comment thread interfaces/litmus_auth/v0/README.md Outdated
@PietroPasotti
Copy link
Copy Markdown
Contributor

@james-garner-canonical

@james-garner-canonical
Copy link
Copy Markdown
Contributor

This looks good to me, but for some reason no tests seem to be collected when I try running the interface tests from this branch (run) -- any ideas?

Also if there's an interface library, let's mention it at the start of the readme.

michaeldmitry and others added 2 commits August 27, 2025 10:07
Co-authored-by: PietroPasotti <starfire.daemon@gmail.com>
Signed-off-by: Michael Dmitry <33381599+michaeldmitry@users.noreply.github.com>
@michaeldmitry
Copy link
Copy Markdown
Contributor Author

This looks good to me, but for some reason no tests seem to be collected when I try running the interface tests from this branch (run) -- any ideas?

Also if there's an interface library, let's mention it at the start of the readme.

@james-garner-canonical I updated this PR with a temp branch that has the tests, but the CI doesn't seem to pick it up tho.
It passes locally. Is it because of the Python version maybe?

@michaeldmitry
Copy link
Copy Markdown
Contributor Author

@james-garner-canonical after trying to run the workflow from this branch , we get a diff error. That error is probably due to setting up python 3.8 in the workflow.

@james-garner-canonical
Copy link
Copy Markdown
Contributor

@michaeldmitry
Copy link
Copy Markdown
Contributor Author

Progress! We're now failing to install dependencies because Python 3.10 is too low 😃

Yeah the lib needs python ~= 3.12.0

Copy link
Copy Markdown
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, tests pass with Python 3.12!

@james-garner-canonical james-garner-canonical merged commit 4914c3f into main Aug 29, 2025
8 checks passed
@james-garner-canonical james-garner-canonical deleted the TAP-700 branch August 29, 2025 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants