Add S3 v1 interface and update S3 v0 interface#306
Conversation
deusebio
left a comment
There was a problem hiding this comment.
Thank you @theoctober19th for adding this! I believe it is very beneficial.
I just have a couple of questions on whether some fields are really optional, but otherwise everything looks good!
james-garner-canonical
left a comment
There was a problem hiding this comment.
Chiming in with my review since @dimaqq requested it. I'd love to see more in the v1 readme about the migration strategy for deployments, as well as some documentation (or a pointer to library docs) explaining which library versions support which interface versions.
|
Hi @theoctober19th @Batalex @deusebio, we're moving towards archiving this repo very soon, however interface specifications live on in the I'm happy to merge this PR and migrate the interface definition to I also posted some documentation feedback, most of which is minor and can be skipped, but it would be great to get some documentation of migration strategies and the library versions that support the different interface versions. |
|
Hi @james-garner-canonical, thank you for the information that this repo is soon to be archived. I'll do the needful to get this merged ASAP. |
…rfaces into s3-v1
Co-authored-by: James Garner <james.garner@canonical.com> Signed-off-by: Bikalpa Dhakal <theoctober19th@gmail.com>
Co-authored-by: James Garner <james.garner@canonical.com> Signed-off-by: Bikalpa Dhakal <theoctober19th@gmail.com>
…rfaces into s3-v1
|
Hi @james-garner-canonical, I've added the requested changes in the PR. Can you have a look again? |
deusebio
left a comment
There was a problem hiding this comment.
Looks good! Thanks @theoctober19th !
This PR aims to introduce a newer version of
s3interface (v1), which is going to be implemented by thes3-integratoron2/track going further. The news3-integratorcharm is added with features of automatic bucket creation and verification, as per the spec DA171.The major changes in the interface is that now the sensitive information like
access-keyandsecret-keyare to be passed by encapsulating them in a Juju secret -- while other things being similar. The interface now also adds for support for both provider and requirer writing the version of the S3 lib they're using -- to enable us to have more flexibility in the future should we have the necessity to have conditional logic based on some specific version of charm lib.This PR also aims to update some old and obsolete information on the
s3v0 interface.