feat: allow specifying a Juju snap revision#185
Open
tonyandrewmeyer wants to merge 4 commits into
Open
Conversation
govulncheck flags four crypto/x509 and crypto/tls vulnerabilities in go1.26.1, all fixed in go1.26.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
james-garner-canonical
approved these changes
May 11, 2026
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Looks good to me!
If the channel and revision don't match, then we'll fail with an error from snap like error: snap "juju" is not available on 3/stable but other tracks exist., which isn't the friendliest, but seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces CONCIERGE_JUJU_REVISION and the corresponding config option to allow specifying a specific Juju snap revision to be installed. This allows installation of a specific CLI tool revision, which may be required to work around bugs with Juju (and also effectively provides pinning to a specific revision of Juju, analogous to hash pinning).
Behaviour:
snapwhen both are set; Snap uses the revision (channel is used for tracking).snapto fail; that error bubbles up through SnapHandler.Prepare → JujuHandler.install → mgr.Prepare and is reported normally.Fixes #170