fix: work around Viper dropping nil-value keys#190
Merged
tonyandrewmeyer merged 3 commits intoMay 19, 2026
Conversation
james-garner-canonical
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viper drops nil value keys when loading YAML, which means that a Concierge config that uses a nil value key to indicate that something should happen (like enabling specific features) doesn't work.
We already have a workaround for this for Snap entries, so this PR re-uses that to apply it to the K8s features as well (microk8s uses a list, lxd and google don't have similar items).
Fixes #189