Skip to content

[DPE-9443] Otel distribution cleanup#1532

Merged
dragomirp merged 6 commits into
mainfrom
otel-cleanup
Apr 2, 2026
Merged

[DPE-9443] Otel distribution cleanup#1532
dragomirp merged 6 commits into
mainfrom
otel-cleanup

Conversation

@dragomirp

@dragomirp dragomirp commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Copy old otel distribution cleanup from the old tracing lib.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@dragomirp dragomirp added the bug Something isn't working as expected label Mar 18, 2026
@github-actions github-actions Bot added the Libraries: OK The charm libs used are OK and in-sync label Mar 18, 2026
Comment thread src/charm.py Fixed
@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.82%. Comparing base (6cbfaf9) to head (64bb7b0).
⚠️ Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
+ Coverage   75.68%   75.82%   +0.13%     
==========================================
  Files          17       17              
  Lines        4459     4484      +25     
  Branches      680      684       +4     
==========================================
+ Hits         3375     3400      +25     
  Misses        850      850              
  Partials      234      234              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/charm.py
Comment thread src/utils.py
@dragomirp dragomirp marked this pull request as ready for review March 19, 2026 00:39
@dragomirp dragomirp requested a review from a team as a code owner March 19, 2026 00:39
@dragomirp dragomirp requested review from carlcsaposs-canonical, juju-charm-bot, marceloneppel and taurus-forever and removed request for a team March 19, 2026 00:39
Comment thread poetry.lock

@taurus-forever taurus-forever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do NOT like the fat of ops/otel workaround in PostgreSQL charm for old Juju.
Let me ask the proper assist from COS/Ops team one more time here.

marceloneppel
marceloneppel previously approved these changes Mar 19, 2026
@dragomirp dragomirp changed the base branch from main to jammy-runners April 2, 2026 01:59
@dragomirp dragomirp changed the base branch from jammy-runners to main April 2, 2026 01:59
Comment thread src/utils.py
Comment thread spread.yaml

@taurus-forever taurus-forever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😢 😢 😢 😢 😢

Please change from debug to warning/info the fact of this call.

Comment thread src/utils.py
@dragomirp dragomirp merged commit 8df1151 into main Apr 2, 2026
392 of 405 checks passed
@dragomirp dragomirp deleted the otel-cleanup branch April 2, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: OK The charm libs used are OK and in-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants