feat(config): complete update_config with API apply, restart engine, and bridges#180
Draft
marceloneppel wants to merge 2 commits into
Draft
feat(config): complete update_config with API apply, restart engine, and bridges#180marceloneppel wants to merge 2 commits into
marceloneppel wants to merge 2 commits into
Conversation
marceloneppel
changed the title
marceloneppel
changed the base branch from
tls-4-tests
to
skl-01-update-config-3-template
July 11, 2026 01:42
…and bridges The library now owns the full config-update flow (steps 3-10) instead of the charm. update_config renders, applies Patroni-controlled parameters via the API, runs the TLS/pending-restart decision engine, honors the VM snap gate, and persists the config/user hashes -- all in the lib. The substrate-tangled pieces of the restart trigger, endpoint refresh, and monitoring/LDAP service restarts ride charm-side through three injected bridge callables (request_restart, refresh_endpoints, restart_services) until their own migration phases, so the two HIGH-risk substrate diffs in the restart trigger (VM pops postgresql_restarted; K8s updates the metrics scrape job) stay out of the library. is_tls_enabled and generate_config_hash internalize; user_hash stays injected. The config hash is byte-compatible with the charm's, so charm adoption does not force a spurious restart. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
update_config always renders patroni.yml with enable_tls=is_tls_enabled, but the orchestration tests mocked render_patroni_yml_file without checking that kwarg, so a regression hardcoding or inverting the TLS flag would still pass. Pin that the flag reaches the render call for both the enabled and disabled states. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
force-pushed
the
skl-01-update-config-3-template
branch
from
July 11, 2026 16:12
cba92af to
fdf2a44
Compare
marceloneppel
force-pushed
the
feature/migrate-update-config
branch
from
July 11, 2026 16:12
08f5993 to
40752dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The capstone of the migration: the
update_configorchestration itself — apply the Patroni REST API config patch, decide reload-vs-restart, and persist the config hash — plus the charm-owned bridges it calls back into.Solution
managers/config.py:update_configorchestration wiringapply_api_config,handle_restart_need,is_tls_enabled,is_restart_pending,generate_config_hash, and config-hash persistence.request_restart,refresh_endpoints,restart_services), matching the TLS migration's collaborator-injection pattern; declared@abstractmethodon the abstract charm and stubbed per substrate.apply_api_configdirectly.Final PR in the update_config stack (base
skl-01-update-config-3-template). Charm adoption — deleting the charm-side copies, catchingDeployedWithoutTrustError, wiring the bridges — follows in per-charm PRs once the lib is released.Checklist