fix: free trial chip in /pro/subscribe#16309
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the /pro/subscribe ProductSummary UI to improve the visual placement of the “Free trial on checkout” status chip relative to the checkout button.
Changes:
- Adjust vertical alignment in the desktop/tablet ProductSummary action area to align elements to the bottom.
- Add spacing between the free-trial
StatusLabeland thePaymentButton.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| style={{ display: "flex", alignItems: "flex-end" }} | ||
| > | ||
| {product?.canBeTrialled && productUser !== ProductUsers.myself ? ( | ||
| <StatusLabel appearance="positive"> | ||
| <StatusLabel appearance="positive" style={{ marginRight: "1rem" }}> | ||
| Free trial on checkout |
There was a problem hiding this comment.
The spacing between StatusLabel and PaymentButton is currently achieved via marginRight on the label. Since the parent <Col> is already a flex container, consider using gap on the flex container instead to avoid duplicating inline styles on children and keep spacing concerns on the layout wrapper.
| {product?.canBeTrialled && productUser !== ProductUsers.myself ? ( | ||
| <Col size={12}> | ||
| <StatusLabel appearance="positive"> | ||
| <StatusLabel appearance="positive" style={{ marginRight: "1rem" }}> |
There was a problem hiding this comment.
On the small/medium layout the free-trial StatusLabel is rendered in its own full-width <Col> below the <PaymentButton>, so marginRight here won’t affect the label/button spacing. Consider removing this style, or switching to vertical spacing (e.g., margin-top) / colocating the label with the button if you need to adjust their relative positioning.
| <StatusLabel appearance="positive" style={{ marginRight: "1rem" }}> | |
| <StatusLabel appearance="positive"> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16309 +/- ##
=======================================
Coverage 48.30% 48.30%
=======================================
Files 37 37
Lines 5912 5912
=======================================
Hits 2856 2856
Misses 3056 3056 🚀 New features to boost your workflow:
|
I was also looking at the chip component which might look better. @polgarp would be the best person to suggest what to do here |
|
@abhigyanghosh30 you are right! Status labels are deprecated and the recommendation is to use chips instead - also since this is a small piece of additional piece of information. |
1788655 to
0d9807f
Compare


Done
QA
./run serveordotrunIssue / Card
Fixes #
Screenshots
Before:

After:

Help
QA steps - Commit guidelines