Fix broken kernel.org commit links#16381
Open
YukiCodepth wants to merge 2 commits into
Open
Conversation
YukiCodepth
requested a deployment
to
percy-testing
GitHub Actions
Waiting
|
YukiCodepth is not a collaborator of the repo |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates CVE patch-details rendering to handle kernel commit metadata strings that may include extra trailing text, ensuring generated links point to the correct commit.
Changes:
- Extract the first whitespace-delimited token from
patch.content.introducedandpatch.content.fixedwhen building git.kernel.org links.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+441
to
+443
| <a href="https://git.kernel.org/linus/{{ patch.content.introduced.split()[0] }}">{{ patch.content.introduced[:7] }}</a>, | ||
| fixed by | ||
| <a href="https://git.kernel.org/linus/{{ patch.content.fixed }}">{{ patch.content.fixed[:7] }}</a> | ||
| <a href="https://git.kernel.org/linus/{{ patch.content.fixed.split()[0] }}">{{ patch.content.fixed[:7] }}</a> |
Comment on lines
+441
to
+443
| <a href="https://git.kernel.org/linus/{{ patch.content.introduced.split()[0] }}">{{ patch.content.introduced[:7] }}</a>, | ||
| fixed by | ||
| <a href="https://git.kernel.org/linus/{{ patch.content.fixed }}">{{ patch.content.fixed[:7] }}</a> | ||
| <a href="https://git.kernel.org/linus/{{ patch.content.fixed.split()[0] }}">{{ patch.content.fixed[:7] }}</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken
git.kernel.orglinks generated for CVE pages.Changes
(7.0-rc7)from commit hashes before generating kernel.org URLsVerification
Verified that URLs generated without the version suffix open the correct kernel.org commit page instead of returning "No repositories found".
Fixes #16333