ci: consolidate PR checks into taskfile workflow#16384
Open
Onibenjo wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the repository’s PR CI checks into a Taskfile-driven GitHub Actions workflow, replacing the legacy dotrun-based workflow and updating contributor documentation to reflect Taskfile as the primary local development entrypoint.
Changes:
- Replaces
.github/workflows/pr.yamlwith a Taskfile-based.github/workflows/pr-with-task.yamlwhile keeping the workflow name as PR checks. - Expands
taskfile.yamlwith dedicatedtest-*andlint-*tasks plustest/lintaggregators to mirror CI checks. - Updates docs/templates (README/HACKING/ARCHITECTURE/PR template) to recommend Taskfile and mark dotrun as deprecated.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
taskfile.yaml |
Adds granular test/lint tasks and aggregators to support CI job mapping. |
README.md |
Updates local development guidance and dotrun deprecation messaging. |
HACKING.md |
Switches primary run instructions to Taskfile; keeps dotrun as deprecated fallback. |
ARCHITECTURE.md |
Updates architecture docs to reflect Taskfile-based local development. |
.github/workflows/pr.yaml |
Removes the old dotrun-based PR checks workflow. |
.github/workflows/pr-with-task.yaml |
Introduces the consolidated Taskfile-based “PR checks” workflow and restores missing jobs (e.g., Codecov, validate-deploy, inclusive naming). |
.github/pull_request_template.md |
Updates contributor QA instructions to use task start. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
67
to
73
| @@ -54,37 +72,177 @@ jobs: | |||
| - name: Build project | |||
| run: task build | |||
There was a problem hiding this comment.
zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
petesfrench
reviewed
May 27, 2026
Contributor
petesfrench
left a comment
There was a problem hiding this comment.
LGTM. Couple minor comments
c5d4bcc to
ce7c1b9
Compare
a403f8b to
e540858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
pr.yamlwith a feature-complete taskfile-basedpr-with-task.yaml(13 jobs preserving all 9 branch-protected required-check names).README.md,HACKING.md,ARCHITECTURE.md, and.github/pull_request_template.mdto point at Taskfile and markdotrunas deprecated.playwright.yamlandforms.yamlstill use dotrun.QA
Issue / Card
Fixes WD-36293
https://warthogs.atlassian.net/browse/WD-36293
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines