Skip to content

ci: consolidate PR checks into taskfile workflow#16384

Open
Onibenjo wants to merge 1 commit into
mainfrom
WD-36293/cleanup-actions
Open

ci: consolidate PR checks into taskfile workflow#16384
Onibenjo wants to merge 1 commit into
mainfrom
WD-36293/cleanup-actions

Conversation

@Onibenjo
Copy link
Copy Markdown
Contributor

@Onibenjo Onibenjo commented May 26, 2026

Done

  • Replaces the dotrun-based pr.yaml with a feature-complete taskfile-based pr-with-task.yaml (13 jobs preserving all 9 branch-protected required-check names).
  • Updates README.md, HACKING.md, ARCHITECTURE.md, and .github/pull_request_template.md to point at Taskfile and mark dotrun as deprecated.
  • Out of scope (tracked as follow-ups): playwright.yaml and forms.yaml still use dotrun.

QA

  • All 9 required status checks on `main` (check-prettier, lint-jinja, lint-js, lint-python, lint-scss, run-image, test-js, test-python, validate-deploy) report status on this PR.
  • Additional jobs (start, build, lint-ts, Inclusive-naming-check) also report status.
  • No duplicate workflow runs (only `PR checks` workflow triggers).
  • [List additional steps to QA the new features or prove the bug has been resolved]

Issue / Card

Fixes WD-36293
https://warthogs.atlassian.net/browse/WD-36293

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

Copilot AI review requested due to automatic review settings May 26, 2026 14:07
@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the repository’s PR CI checks into a Taskfile-driven GitHub Actions workflow, replacing the legacy dotrun-based workflow and updating contributor documentation to reflect Taskfile as the primary local development entrypoint.

Changes:

  • Replaces .github/workflows/pr.yaml with a Taskfile-based .github/workflows/pr-with-task.yaml while keeping the workflow name as PR checks.
  • Expands taskfile.yaml with dedicated test-* and lint-* tasks plus test/lint aggregators to mirror CI checks.
  • Updates docs/templates (README/HACKING/ARCHITECTURE/PR template) to recommend Taskfile and mark dotrun as deprecated.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
taskfile.yaml Adds granular test/lint tasks and aggregators to support CI job mapping.
README.md Updates local development guidance and dotrun deprecation messaging.
HACKING.md Switches primary run instructions to Taskfile; keeps dotrun as deprecated fallback.
ARCHITECTURE.md Updates architecture docs to reflect Taskfile-based local development.
.github/workflows/pr.yaml Removes the old dotrun-based PR checks workflow.
.github/workflows/pr-with-task.yaml Introduces the consolidated Taskfile-based “PR checks” workflow and restores missing jobs (e.g., Codecov, validate-deploy, inclusive naming).
.github/pull_request_template.md Updates contributor QA instructions to use task start.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread .github/workflows/pr-with-task.yaml Outdated
Comment thread .github/workflows/pr-with-task.yaml Outdated
Comment on lines 67 to 73
@@ -54,37 +72,177 @@ jobs:
- name: Build project
run: task build
Copy link
Copy Markdown

@github-advanced-security github-advanced-security AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
Comment thread .github/workflows/pr-with-task.yaml Fixed
@Onibenjo Onibenjo changed the title ci: consolidate PR checks into taskfile workflow fix: unblock test-python CI after discourse 7.2.0 bump May 26, 2026
@Onibenjo Onibenjo changed the title fix: unblock test-python CI after discourse 7.2.0 bump ci: consolidate PR checks into taskfile workflow May 26, 2026
Copy link
Copy Markdown
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple minor comments

Comment thread .github/workflows/pr-with-task.yaml
Comment thread taskfile.yaml Outdated
@Onibenjo Onibenjo force-pushed the WD-36293/cleanup-actions branch from a403f8b to e540858 Compare June 1, 2026 11:19
@Onibenjo Onibenjo requested a review from petesfrench June 1, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants