ci(percy): only run snapshot comparison on initial push and manually after#16397
Open
petesfrench wants to merge 3 commits into
Open
ci(percy): only run snapshot comparison on initial push and manually after#16397petesfrench wants to merge 3 commits into
petesfrench wants to merge 3 commits into
Conversation
Demo
Jenkins 
demos.haus 
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Percy CI workflows so visual snapshot comparisons run on initial PR events and can be manually retriggered via labeling, instead of running on every PR push.
Changes:
- Removes automatic Percy runs on
synchronizeevents. - Adds
labeledtriggers intended for manualrun-percyexecution. - Adds path filters for template, Sass, frontend JS, navigation, and snapshot config changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/percy.yml |
Updates Percy workflow triggers and job gating for same-repository PRs. |
.github/workflows/percy-fork-pr.yml |
Updates Percy workflow triggers and job gating for fork PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| if: > | ||
| github.event.pull_request.head.repo.full_name == github.repository && | ||
| (github.event_name != 'labeled' || github.event.label.name == 'run-percy') |
| if: github.event.pull_request.head.repo.full_name != github.repository | ||
| if: > | ||
| github.event.pull_request.head.repo.full_name != github.repository && | ||
| (github.event_name != 'labeled' || github.event.label.name == 'run-percy') |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16397 +/- ##
==========================================
+ Coverage 48.33% 48.36% +0.03%
==========================================
Files 37 37
Lines 5905 5905
==========================================
+ Hits 2854 2856 +2
+ Misses 3051 3049 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
run-percylabelQA
Please review the list of paths to see I have reasonably covered everything.
run-percy, see that it runsIssue / Card
Fixes WD-36846