Small changes requested by the maintainers

Author: FedericoSpada

canopen/objectdictionary/eds.py

@@ -129,7 +129,7 @@ def import_eds(source, node_id):
                 storage_location = None
 
             if object_type in (objectcodes.VAR, objectcodes.DOMAIN):
-                var = build_variable(eds, section, node_id, index, is_domain=object_type==objectcodes.DOMAIN)
+                var = build_variable(eds, section, node_id, index, is_domain=object_type == objectcodes.DOMAIN)
                 od.add_object(var)
             elif object_type == objectcodes.ARRAY and eds.has_option(section, "CompactSubObj"):
                 arr = ODArray(name, index)
@@ -162,7 +162,7 @@ def import_eds(source, node_id):
                     object_type = int(eds.get(section, "ObjectType"), 0)
                 except NoOptionError:
                     object_type = objectcodes.VAR
-                var = build_variable(eds, section, node_id, index, subindex, is_domain=object_type==objectcodes.DOMAIN)
+                var = build_variable(eds, section, node_id, index, subindex, is_domain=object_type == objectcodes.DOMAIN)
                 entry.add_member(var)
 
         # Match [index]Name

test/test_eds.py

@@ -111,7 +111,7 @@ def test_variable(self):
         self.assertEqual(var.name, 'Producer heartbeat time')
         self.assertEqual(var.data_type, canopen.objectdictionary.UNSIGNED16)
         self.assertEqual(var.access_type, 'rw')
-        self.assertEqual(var.is_domain, False)
+        self.assertFalse(var.is_domain)
         self.assertEqual(var.default, 0)
         self.assertFalse(var.relative)
 
@@ -133,7 +133,7 @@ def test_record(self):
         self.assertEqual(var.subindex, 1)
         self.assertEqual(var.data_type, canopen.objectdictionary.UNSIGNED32)
         self.assertEqual(var.access_type, 'ro')
-        self.assertEqual(var.is_domain, False)
+        self.assertFalse(var.is_domain)
 
     def test_record_with_limits(self):
         int8 = self.od[0x3020]
@@ -168,7 +168,7 @@ def test_array_compact_subobj(self):
         self.assertEqual(var.subindex, 5)
         self.assertEqual(var.data_type, canopen.objectdictionary.UNSIGNED32)
         self.assertEqual(var.access_type, 'ro')
-        self.assertEqual(var.is_domain, False)
+        self.assertFalse(var.is_domain)
 
     def test_explicit_name_subobj(self):
         name = self.od[0x3004].name
@@ -200,7 +200,7 @@ def test_dummy_variable(self):
         self.assertEqual(var.name, 'Dummy0003')
         self.assertEqual(var.data_type, canopen.objectdictionary.INTEGER16)
         self.assertEqual(var.access_type, 'const')
-        self.assertEqual(var.is_domain, False)
+        self.assertFalse(var.is_domain)
         self.assertEqual(len(var), 16)
 
     def test_dummy_variable_undefined(self):
@@ -225,7 +225,7 @@ def test_read_domain_object(self):
         self.assertEqual(var.name, 'DOMAIN object')
         self.assertEqual(var.data_type, canopen.objectdictionary.UNSIGNED32)
         self.assertEqual(var.access_type, 'rw')
-        self.assertEqual(var.is_domain, True)
+        self.assertTrue(var.is_domain)
 
     def test_read_domain_subobject(self):
         record = self.od[0x3064]
@@ -236,7 +236,7 @@ def test_read_domain_subobject(self):
         self.assertEqual(var.name, 'DOMAIN sub-object')
         self.assertEqual(var.data_type, canopen.objectdictionary.UNSIGNED32)
         self.assertEqual(var.access_type, 'rw')
-        self.assertEqual(var.is_domain, True)
+        self.assertTrue(var.is_domain)
 
     def test_roundtrip_domain_objects(self):
         # ObjectType==DOMAIN survive an EDS export/import round-trip
@@ -246,10 +246,10 @@ def test_roundtrip_domain_objects(self):
             dest.name = 'mock.eds'
             dest.seek(0)
             od2 = canopen.import_od(dest)
-        self.assertEqual(od2['Producer heartbeat time'].is_domain, False)
-        self.assertEqual(od2['Identity object']['Vendor-ID'].is_domain, False)
-        self.assertEqual(od2[0x3063].is_domain, True)
-        self.assertEqual(od2[0x3064][1].is_domain, True)
+        self.assertFalse(od2['Producer heartbeat time'].is_domain)
+        self.assertFalse(od2['Identity object']['Vendor-ID'].is_domain)
+        self.assertTrue(od2[0x3063].is_domain)
+        self.assertTrue(od2[0x3064][1].is_domain)
 
 
     def test_comments(self):