Skip to content

Commit d6de8ee

Browse files
committed
Avoid else after raise.
Simplify by using the walrus operator.
1 parent 8d4ea96 commit d6de8ee

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

canopen/objectdictionary/__init__.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -500,11 +500,10 @@ def encode_phys(self, value: Union[int, bool, float, str, bytes]) -> int:
500500
def decode_desc(self, value: int) -> str:
501501
if not self.value_descriptions:
502502
raise ObjectDictionaryError("No value descriptions exist")
503-
elif value not in self.value_descriptions:
503+
elif (desc := self.value_descriptions.get(value)) is None:
504504
raise ObjectDictionaryError(
505505
f"No value description exists for {value}")
506-
else:
507-
return self.value_descriptions[value]
506+
return desc
508507

509508
def encode_desc(self, desc: str) -> int:
510509
if not self.value_descriptions:

0 commit comments

Comments
 (0)