SV UI: support activity weights for GrantFeaturedAppRight#6387
Merged
Conversation
Contributor
the form without anything filled in |
Contributor
a valid proposal pre submission |
Contributor
an invalid weight |
Contributor
a submitted proposal |
pawelperek-da
approved these changes
Jul 13, 2026
pawelperek-da
left a comment
pawelperek-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Please take a look at my nit
| "grant-featured-app", | ||
| ) { implicit webDriver => | ||
| fillOutTextField("grant-featured-app-idValue", providerPartyId) | ||
| inside(find(id("grant-featured-app-activityWeight"))) { case Some(element) => |
Contributor
There was a problem hiding this comment.
Maybe you could use fillOutTextField like above?
Contributor
from the POV of someone who has to vote |
Contributor
|
Please fix the release notes conflict again |
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam
force-pushed
the
dfordivam/cip-104-sv-fa-weight-ui-1
branch
from
ddcdf21 to
f3e7670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6237
Adds support for specifying weight (decimal value) in GrantFeaturedAppRight UI flow.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines