PropertyChangedInterfaceAnalyser behavior

[schokee]

Is it possible to force use of RaisePropertyChangedOrChangingNameType.String?

The concrete use case: using PropertyChanged.SourceGenerator (PCSG) with Caliburn.Micro (CM)

1. CM defines PropertyChangedBase.OnPropertyChanged(PropertyChangedEventArgs) as non-virtual (see also: PropertyChangedBase)
2. PCSG defaults to using PropertyChangedBase.OnPropertyChanged

In this scenario, is it possible to have PCSG default to using the virtual method: PropertyChangedBase.NotifyOfPropertyChange(string propertyName) instead of OnPropertyChanged? Maybe in the 'matching' comparison, 'matching' virtual methods could take precedence over 'matching' non-virtual methods?

I suppose PropertyChangedBase.Set<T> could also be considered in place of the generated property setter implementation.

[schokee]

FYI - prioritising NotifyOfPropertyChange in .EditorConfig using propertychanged.onpropertychanged_method_name generates the following warning:

warning INPC006: Found one or more methods called 'NotifyOfPropertyChange' to raise the PropertyChanged event, but they had unrecognised signatures or were inaccessible. These methods will not be used

[schokee]

I've looked into this further and can confirm it's a bug in InterfaceAnalyzer.DiscoverMethods.

PropertyChangedBase has 2 overloads of the method NotifyOfPropertyChange:

• the first declaration has a string parameter
• the second declaration has an Expression parameter

The bug is in the InterfaceAnalyzer.DiscoverMethods loop (lines 362-378). Even though it matches the first overload, it doesn't break out of the loop. Trying to match the second overload fails, resulting in methodNamesFoundButDidntKnowHowToCall.

This was also reported in #49.

[canton7]

See #51