Skip to content

feat: provide postgres profile #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patricebender wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: provide postgres profile #1491

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b13e48
feat: provide `postgres` profile
patricebender Feb 3, 2026
9af117b
review comment
patricebender Feb 17, 2026
58ff0cf
Merge branch 'main' into patrice/pg
patricebender Feb 17, 2026
756d43d
Merge branch 'main' into patrice/pg
patricebender Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion postgres/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"[production]": {
"kind": "postgres"
},
"[pg!]": {
"[development]": {
Copy link
Copy Markdown
Contributor

@swaldmann swaldmann Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes Postgres the default for all non-production scenarios though. Might be intended, but we defaulted to SQLite before so this is an incompatible change.

It's then also doing this merge of SQLite and Postgres credentials for a new project:
cds init bookshop --add sample --nodejs && cd bookshop && cds add postgres && cds env requires.db:

{
  impl: '@cap-js/sqlite',
  credentials: {
    url: ':memory:',
    host: 'localhost',
    port: 5432,
    user: 'postgres',
    password: 'postgres',
    database: 'postgres'
  },
  data: [ 'db/data', 'db/csv', 'test/data' ],
  pool: { max: 1 },
  kind: 'sqlite'
}

I propose instead you put the credentials under cds.requires.kinds.postgres, similar to how it's done in @cap-js/hana:
https://github.com/cap-js/cds-dbs/blob/main/hana/package.json#L58-L72

"kind": "postgres",
"credentials": {
"host": "localhost",
Expand All @@ -55,6 +55,12 @@
"password": "postgres",
"database": "postgres"
}
},
"[pg]": {
"kind": "postgres"
},
"[postgres]": {
"kind": "postgres"
}
},
"postgres": {
Expand Down