Skip to content

feat(pool): make builtin pool the default #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sjvans wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(pool): make builtin pool the default #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbaf12b
[cds^10] make builtin pool the default
sjvans Mar 18, 2026
a33ad36
Change pool selection logic in generic-pool.js
sjvans Mar 18, 2026
d01b489
Merge branch 'main' into make-builtin-pool-the-default
johannes-vogel May 12, 2026
d89584f
fix format
johannes-vogel May 12, 2026
82f8df0
Merge branch 'main' into make-builtin-pool-the-default
sjvans May 18, 2026
dd7bde4
Merge branch 'main' into make-builtin-pool-the-default
johannes-vogel May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db-service/lib/common/generic-pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const cds = require('@sap/cds')
const LOG = cds.log('db')

const use_new_pool = cds.requires.db?.pool?.builtin || cds.env.features.pool === 'builtin'
const use_new_pool = cds.requires.db?.pool?.builtin === false || cds.env.features.pool === 'generic-pool' ? false : true
const createPool = use_new_pool ? (...args) => new Pool(...args) : require('generic-pool').createPool

function ConnectionPool (factory, tenant) {
Expand Down
9 changes: 6 additions & 3 deletions db-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,14 @@
"scripts": {
"test": "cds-test"
},
"dependencies": {
"peerDependencies": {
"@sap/cds": ">=9.8",
"generic-pool": "^3.9.0"
},
"peerDependencies": {
"@sap/cds": ">=9.8"
"peerDependenciesMeta": {
"generic-pool": {
"optional": true
}
},
"license": "Apache-2.0"
}