fix: inline numeric val nodes in column expression xpr trees#1599
Draft
hm23 wants to merge 2 commits into
Draft
Conversation
Numeric val nodes inside xpr trees (e.g. CASE WHEN THEN/ELSE values) used as SELECT column expressions are now rendered as inline SQL literals instead of bound parameters. This fixes "Cannot set parameter at row: 1. Argument must be a string" errors with hdb v2 when calculated elements use CASE WHEN with integer return values. The existing column_expr() guard only inlined bare numeric val nodes. The new _xprWithInlineNumericVals() helper recursively marks numeric vals inside xpr subtrees with param:false using prototype-based non-mutating wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric val nodes inside xpr trees (e.g. CASE WHEN THEN/ELSE values) used as SELECT column expressions are now rendered as inline SQL literals instead of bound parameters. This fixes "Cannot set parameter at row: 1. Argument must be a string" errors with hdb v2 when calculated elements use CASE WHEN with integer return values.
The existing column_expr() guard only inlined bare numeric val nodes. The new _xprWithInlineNumericVals() helper recursively marks numeric vals inside xpr subtrees with param:false using prototype-based non-mutating wrappers.