fix: calc element with exists through association#1608
Merged
Conversation
…ntext When a calculated element containing `exists <assoc>[filter]` is accessed through another association (e.g. `project.isUserNotMember`), the join tree must include a JOIN for the preceding association so the exists subquery can correlate against it. Two fixes in infer/index.js: - mergePathsIntoJoinTree: detect `exists` in xpr and merge only the prefix path as a JOIN, not the exists-target association itself - isColumnJoinRelevant: when a managed association was already traversed, encountering an unmanaged association must return true
patricebender
requested review from
BobdenOs,
danjoa,
johannes-vogel,
sjvans and
stewsk
as code owners
patricebender
changed the title
stewsk
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a calculated element containing
exists <assoc>[filter]is accessed through another association (e.g.project.isUserNotMember), the join tree must include a JOIN for the preceding association so the exists subquery can correlate against it.existsin xpr and merge only the prefix path as a JOIN, not the exists-target association itself