From b97bf21cc9dd6724fb178908c2d9c46bc30f041d Mon Sep 17 00:00:00 2001 From: Dalibor Cosic Date: Thu, 24 Apr 2025 23:55:32 +0200 Subject: [PATCH 1/3] feat: App Shortcuts, Android - Allow referencing custom icons from "drawable" folder #494 --- .../plugins/appshortcuts/AppShortcutsHelper.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/app-shortcuts/android/src/main/java/io/capawesome/capacitorjs/plugins/appshortcuts/AppShortcutsHelper.java b/packages/app-shortcuts/android/src/main/java/io/capawesome/capacitorjs/plugins/appshortcuts/AppShortcutsHelper.java index 45b3e9ec..35e24864 100644 --- a/packages/app-shortcuts/android/src/main/java/io/capawesome/capacitorjs/plugins/appshortcuts/AppShortcutsHelper.java +++ b/packages/app-shortcuts/android/src/main/java/io/capawesome/capacitorjs/plugins/appshortcuts/AppShortcutsHelper.java @@ -60,7 +60,13 @@ public static List createShortcutInfoCompatList(JSArray shor if (androidIcon != null) { try { - int iconResId = context.getResources().getIdentifier((String) androidIcon, "drawable", "android"); + // First try to get drawable from app resources + int iconResId = context.getResources().getIdentifier((String) androidIcon, "drawable", context.getPackageName()); + if (iconResId == 0) { + // If not found in app resources, try system resources + iconResId = context.getResources().getIdentifier((String) androidIcon, "drawable", "android"); + } + shortcutInfoCompat.setIcon(IconCompat.createWithResource(context, iconResId)); } catch (Exception exception) { shortcutInfoCompat.setIcon(IconCompat.createWithResource(context, (int) androidIcon)); From 78c96ed4407ddf248007a50a66184e963be9516f Mon Sep 17 00:00:00 2001 From: Dalibor Cosic Date: Fri, 25 Apr 2025 10:58:09 +0200 Subject: [PATCH 2/3] Changeset --- .changeset/pretty-pots-float.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/pretty-pots-float.md diff --git a/.changeset/pretty-pots-float.md b/.changeset/pretty-pots-float.md new file mode 100644 index 00000000..b3fa0683 --- /dev/null +++ b/.changeset/pretty-pots-float.md @@ -0,0 +1,5 @@ +--- +'@capawesome/capacitor-app-shortcuts': minor +--- + +Allow using custom icons from "drawable" folder in Android From 4522a9060d7c62b756b83de13d9ac72c24a63326 Mon Sep 17 00:00:00 2001 From: Robin Genz Date: Fri, 25 Apr 2025 11:21:09 +0200 Subject: [PATCH 3/3] Update .changeset/pretty-pots-float.md --- .changeset/pretty-pots-float.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/pretty-pots-float.md b/.changeset/pretty-pots-float.md index b3fa0683..f3ba77d7 100644 --- a/.changeset/pretty-pots-float.md +++ b/.changeset/pretty-pots-float.md @@ -2,4 +2,4 @@ '@capawesome/capacitor-app-shortcuts': minor --- -Allow using custom icons from "drawable" folder in Android +feat(android): support custom icons