Skip to content

feat(app-shortcuts): support custom icons on Android #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robingenz merged 3 commits into from
Apr 25, 2025
Merged

feat(app-shortcuts): support custom icons on Android #495

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b97bf21
feat: App Shortcuts, Android - Allow referencing custom icons from "d…
co-dax Apr 24, 2025
78c96ed
Changeset
co-dax Apr 25, 2025
4522a90
Update .changeset/pretty-pots-float.md
robingenz Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...roid/src/main/java/io/capawesome/capacitorjs/plugins/appshortcuts/AppShortcutsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@ public static List<ShortcutInfoCompat> createShortcutInfoCompatList(JSArray shor

if (androidIcon != null) {
try {
int iconResId = context.getResources().getIdentifier((String) androidIcon, "drawable", "android");
// First try to get drawable from app resources
int iconResId = context.getResources().getIdentifier((String) androidIcon, "drawable", context.getPackageName());
if (iconResId == 0) {
// If not found in app resources, try system resources
iconResId = context.getResources().getIdentifier((String) androidIcon, "drawable", "android");
}

shortcutInfoCompat.setIcon(IconCompat.createWithResource(context, iconResId));
} catch (Exception exception) {
shortcutInfoCompat.setIcon(IconCompat.createWithResource(context, (int) androidIcon));
Expand Down