fix(android-edge-to-edge-support): opt into edge-to-edge on all API levels#840
Draft
robingenz wants to merge 1 commit into
Draft
fix(android-edge-to-edge-support): opt into edge-to-edge on all API levels#840robingenz wants to merge 1 commit into
robingenz wants to merge 1 commit into
Conversation
@capawesome/capacitor-age-signals
@capawesome-team/capacitor-android-battery-optimization
@capawesome/capacitor-android-dark-mode-support
@capawesome/capacitor-android-edge-to-edge-support
@capawesome-team/capacitor-android-foreground-service
@capawesome/capacitor-app-review
@capawesome/capacitor-app-shortcuts
@capawesome/capacitor-app-update
@capawesome/capacitor-apple-sign-in
@capawesome/capacitor-asset-manager
@capawesome/capacitor-background-task
@capawesome/capacitor-badge
@capawesome/capacitor-cloudinary
@capawesome-team/capacitor-datetime-picker
@capawesome-team/capacitor-file-opener
@capawesome/capacitor-file-picker
@capawesome/capacitor-google-sign-in
@capawesome/capacitor-libsql
@capawesome/capacitor-live-update
@capawesome/capacitor-managed-configurations
@capawesome/capacitor-photo-editor
@capawesome/capacitor-pixlive
@capawesome/capacitor-posthog
@capawesome/capacitor-realtimekit
@capawesome/capacitor-screen-orientation
@capawesome/capacitor-screenshot
@capawesome/capacitor-square-mobile-payments
@capawesome/capacitor-superwall
@capawesome/capacitor-torch
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calls
WindowCompat.setDecorFitsSystemWindows(window, false)inEdgeToEdge.enable(). This is the one-line alternative to #839 (Option B: hybrid overlay +Window.setStatusBarColorfallback).This opens a comparison PR against #839 — pick one.
Why
On API <35 with the default
decorFitsSystemWindows = true, theDecorViewauto-consumes system bar insets as padding before they reach the plugin'sWebViewlistener. The overlay positions silently depended on another plugin (@capacitor/keyboard≤ 8.0.1) keeping a no-opsetOnApplyWindowInsetsListeneron the root view, which happened to disable the auto-consumption.@capacitor/keyboard8.0.2+ changed that listener's behavior and 8.0.3 moved it to a different view, breaking the implicit contract:ViewCompat.onApplyWindowInsetscall).Calling
setDecorFitsSystemWindows(false)is the official platform opt-in for edge-to-edge layout and tells the window we handle all insets ourselves. On Android 15+ the platform already does this; on older APIs this is a no-op to app code that was already correctly sized via the plugin's explicit margin logic.Trade-offs vs #839
Test plan
@capacitor/keyboard@8.0.3—setNavigationBarColorandsetStatusBarColorwork.@capacitor/keyboard@8.0.1— no regression.windowOptOutEdgeToEdgeEnforcement=true— still works after explicit opt-in.Close #838