fix(android-edge-to-edge-support): correct WebView margin calculation…#848
Open
rencsikmarian wants to merge 2 commits intocapawesome-team:mainfrom
Open
fix(android-edge-to-edge-support): correct WebView margin calculation…#848rencsikmarian wants to merge 2 commits intocapawesome-team:mainfrom
rencsikmarian wants to merge 2 commits intocapawesome-team:mainfrom
Conversation
… when keyboard is visible
@capawesome/capacitor-age-signals
@capawesome-team/capacitor-android-battery-optimization
@capawesome/capacitor-android-dark-mode-support
@capawesome/capacitor-android-edge-to-edge-support
@capawesome-team/capacitor-android-foreground-service
@capawesome/capacitor-app-review
@capawesome/capacitor-app-shortcuts
@capawesome/capacitor-app-update
@capawesome/capacitor-apple-sign-in
@capawesome/capacitor-asset-manager
@capawesome/capacitor-background-task
@capawesome/capacitor-badge
@capawesome/capacitor-cloudinary
@capawesome-team/capacitor-datetime-picker
@capawesome-team/capacitor-file-opener
@capawesome/capacitor-file-picker
@capawesome/capacitor-google-sign-in
@capawesome/capacitor-libsql
@capawesome/capacitor-live-update
@capawesome/capacitor-managed-configurations
@capawesome/capacitor-photo-editor
@capawesome/capacitor-pixlive
@capawesome/capacitor-posthog
@capawesome/capacitor-realtimekit
@capawesome/capacitor-screen-orientation
@capawesome/capacitor-screenshot
@capawesome/capacitor-square-mobile-payments
@capawesome/capacitor-superwall
@capawesome/capacitor-torch
commit: |
Member
robingenz
requested changes
May 8, 2026
Co-authored-by: Robin Genz <mail@robingenz.dev>
|
Unfortunatley not. Took a deeper look and found out, that the Problem is coming from @capacitor/android |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On API 29, the WindowInsetsCompat.Type.ime() backport is unreliable and
The system handles the IME via adjustResize, so the plugin must not add
imeInsets.bottom — doing so collapses the WebView (#845).
On API 30+, the system does not resize the window for the IME (especially
in edge-to-edge mode, which is enforced on API 35+), so the plugin must
honor imeInsets.bottom or the keyboard covers the WebView content
(reproduced on Samsung Galaxy Z Flip4 / One UI 8 / Android 16).
The previous `keyboardVisible ? 0 : Math.max(...)` ternary was wrong on
both branches: on API 29 it took the else branch (because isVisible(ime())
returns false on that API, even when the IME is up, and double-counted; on
API 35+, it took the if branch and zeroed the margin while the system
expected the app to honor it.
Closes #845, #847."
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).