Add options argument to req.reply#1923
Closed
hm23 wants to merge 7 commits into
Closed
Conversation
hm23
changed the title
hm23
changed the title
sjvans
reviewed
Aug 22, 2025
sjvans
reviewed
Aug 22, 2025
|
|
||
|
|
||
| ### req. reply (results) {.method} | ||
| ### req. reply () {.method} |
Contributor
There was a problem hiding this comment.
Suggested change
| ### req. reply () {.method} | |
| ### req. reply (results) {.method} |
i'd leave this as is. btw, formatting is inconsistent with req. error(), etc. (no space before ())
Co-authored-by: sjvans <30337871+sjvans@users.noreply.github.com>
Contributor
|
@hm23 Would you like to resolve the conflicts or close this PR? |
Contributor
Author
Since I can't remember the reason for opening this PR (I guess it was to align with https://cap.cloud.sap/docs/node.js/best-practices#custom-streaming-beta), and since Sebastian prefers to keep the old version, I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.