Add description for js rules#1946
Merged
Merged
Conversation
chgeo
approved these changes
Jul 4, 2025
chgeo
reviewed
Jul 4, 2025
chgeo
left a comment
chgeo
left a comment
Member
There was a problem hiding this comment.
LGTM.
The detail pages are written manually, with teh good/bad examples taken from the rules' unit test. We can add them later, so that we can publish this with the June release today.
Member
|
@renejeglinsky this should be merged for the June release. |
renejeglinsky
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduced a new set of lint rules targeting JS implementation files, instead of just .cds files.
This PR introduces automatic documentation extraction for these new rules, to be found in list form under
/tools/cds-lint/rules/We do not yet introduce extended documentation per rule for these new rules, as I am not clear yet whether they are automatically generated or maintained manually.