Toggle app scaling from table view#129
Open
thgh wants to merge 1 commit intocaprover:masterfrom
Open
Conversation
githubsaturn
reviewed
Oct 4, 2023
Collaborator
githubsaturn
left a comment
githubsaturn
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few minor comments.
| onClick={async () => { | ||
| const warning = | ||
| 'Do you want to turn this app OFF?' | ||
| if (instanceCount && !window.confirm(warning)) |
Collaborator
There was a problem hiding this comment.
1- I think we should also have a confirmation for turning on to avoid accidental clicks.
2- Suggest using modal.confirm from ant design to match the existing UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still kind of annoying that the table dissappears while it's revalidating. Will send another PR for that.