Show action detail if --action is supplied

Only skip action display if only the app config settings are requested.
As soon as a hook arg is given show at least the label-only version of
the actions.

Author: sebastianfeldmann

src/Runner/Config/Visualizer.php

@@ -128,13 +128,6 @@ public function run(): void
         if (!$this->config->isLoadedFromFile()) {
             throw new RuntimeException('No configuration to read');
         }
-        // make sure to display the necessary parts of the configuration
-        $this->settings->sanityCheck();
-
-        // if at least one hook is given, display the hook actions
-        if (count($this->hooks)) {
-            $this->settings->set(Visualizer\Settings::OPT_ACTIONS, true);
-        }
 
         $this->output->printHeader($this->config);
         $this->displaySettings();
@@ -165,7 +158,7 @@ private function displaySettings(): void
      */
     private function displayHooks(): void
     {
-        if (!$this->settings->show(Visualizer\Settings::OPT_ACTIONS)) {
+        if ($this->isApplicationSettingsOnly()) {
             return;
         }
         $this->output->printHooks($this->hooksToDisplay(), $this->extensive);
@@ -200,4 +193,37 @@ private function shouldHookBeDisplayed(string $name): bool
         }
         return in_array($name, $this->hooks);
     }
+
+    /**
+     * Check if only the application settings should be displayed
+     *
+     * @return bool
+     */
+    private function isApplicationSettingsOnly(): bool
+    {
+        // no app config to display, so clearly no
+        if (!$this->settings->show(Visualizer\Settings::OPT_SETTINGS)) {
+            return false;
+        }
+
+        // check if any action-related stuff has to be shown
+        $actionRelatedStuff = [
+            Visualizer\Settings::OPT_ACTIONS,
+            Visualizer\Settings::OPT_CONDITIONS,
+            Visualizer\Settings::OPT_OPTIONS,
+            Visualizer\Settings::OPT_CONFIG,
+        ];
+        // if so app config is not the only thing to display
+        foreach ($actionRelatedStuff as $option) {
+            if ($this->settings->show($option)) {
+                return false;
+            }
+        }
+        // if we display a specific hook showing the actions makes sense
+        if (!empty($this->hooks)) {
+            return false;
+        }
+        // otherwise we display only the app config
+        return true;
+    }
 }

src/Runner/Config/Visualizer/Output.php

@@ -220,7 +220,7 @@ public function printActions(Config\Hook $config): void
     public function printAction(Config\Action $action): void
     {
         $this->io->write('    - <fg=cyan>' . $action->getLabel() . '</>');
-        if ($action->hasLabel()) {
+        if ($action->hasLabel() && $this->settings->show(Settings::OPT_ACTIONS)) {
             $this->io->write('      <fg=gray>' . $action->getAction() . '</>');
         }
         $this->printOptions($action->getOptions());

src/Runner/Config/Visualizer/Settings.php

@@ -64,33 +64,4 @@ public function show(string $option): bool
     {
         return $this->options[$option] ?? false;
     }
-
-    /**
-     * Check if no config part should be shown
-     *
-     * @return void
-     */
-    public function sanityCheck(): void
-    {
-        $displayAnything = false;
-        foreach ($this->options as $option) {
-            if ($option) {
-                $displayAnything = true;
-                break;
-            }
-        }
-        // nothing should be displayed, show actions by default
-        if (!$displayAnything) {
-            $this->options[self::OPT_ACTIONS] = true;
-            return;
-        }
-
-        // check for anything that needs actions to be displayed
-        foreach ([self::OPT_CONDITIONS, self::OPT_OPTIONS, self::OPT_CONFIG] as $option) {
-            if ($this->options[$option]) {
-                $this->options[self::OPT_ACTIONS] = true;
-                return;
-            }
-        }
-    }
 }

tests/unit/Runner/Config/VisualizerTest.php

@@ -111,6 +111,22 @@ public function testDoesNotShowActionForAppSettings(): void
                ->run();
     }
 
+    public function testDoesShowActionsForAppSettingsWithHookArgument(): void
+    {
+        $path   = realpath(CH_PATH_FILES . '/config/valid.json');
+        $config = Config\Factory::create($path);
+        $io     = $this->createIOMock();
+        $repo   = $this->createRepositoryMock();
+
+        // the better thing to test would be to really check the output
+        $io->expects($this->atMost(11))->method('write');
+
+        $runner = new Visualizer($io, $config, $repo);
+        $runner->display(Visualizer\Settings::OPT_SETTINGS, true)
+            ->setHook('pre-commit')
+            ->run();
+    }
+
     public function testItDisplaysOnlyActions(): void
     {
         $path   = realpath(CH_PATH_FILES . '/config/valid.json');