Skip to content

Commit af4d5ce

Browse files
Move zero hash protection to git library
1 parent e2c1fba commit af4d5ce

4 files changed

Lines changed: 2 additions & 14 deletions

File tree

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"captainhook/secrets": "^0.9.4",
4040
"sebastianfeldmann/camino": "^0.9.2",
4141
"sebastianfeldmann/cli": "^3.3",
42-
"sebastianfeldmann/git": "^3.15.3",
42+
"sebastianfeldmann/git": "^3.16.0",
4343
"symfony/console": "^2.7 || ^3.0 || ^4.0 || ^5.0 || ^6.0 || ^7.0 || ^8.0",
4444
"symfony/filesystem": "^2.7 || ^3.0 || ^4.0 || ^5.0 || ^6.0 || ^7.0 || ^8.0",
4545
"symfony/process": "^2.7 || ^3.0 || ^4.0 || ^5.0 || ^6.0 || ^7.0 || ^8.0"

src/Git/ChangedFiles/Detector/Fallback.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,8 @@ class Fallback extends Detector
3636
*/
3737
public function getChangedFiles(array $filter = []): array
3838
{
39-
$previousHead = $this->io->getArgument(Hooks::ARG_PREVIOUS_HEAD, 'HEAD@{1}');
40-
if (Util::isZeroHash($previousHead)) {
41-
return [];
42-
}
43-
4439
return $this->repository->getDiffOperator()->getChangedFiles(
45-
$previousHead,
40+
$this->io->getArgument(Hooks::ARG_PREVIOUS_HEAD, 'HEAD@{1}'),
4641
'HEAD',
4742
$filter
4843
);

src/Git/ChangedFiles/Detector/PostRewrite.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ public function getChangedFiles(array $filter = []): array
3838
$old = $ranges[0]->from()->id();
3939
$new = $ranges[0]->to()->id();
4040

41-
if (Util::isZeroHash($old) || Util::isZeroHash($new)) {
42-
return [];
43-
}
44-
4541
return $this->repository->getDiffOperator()->getChangedFiles($old, $new, $filter);
4642
}
4743
}

src/Git/ChangedFiles/Detector/PrePush.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ private function collectChangedFiles(array $ranges, array $filter): array
103103
$oldHash = $this->repository->getLogOperator()->getBranchRevFromRefLog($range->to()->branch());
104104
$newHash = 'HEAD';
105105
}
106-
if (Util::isZeroHash($oldHash) || Util::isZeroHash($newHash)) {
107-
continue;
108-
}
109106
if (!empty($oldHash)) {
110107
$files[] = $this->repository->getDiffOperator()->getChangedFiles($oldHash, $newHash, $filter);
111108
}

0 commit comments

Comments
 (0)