@@ -21,8 +21,8 @@ So you'd like to contribute to the `CaptainHook` library? Excellent! Thank you v
2121
2222# Getting started
2323
24- Fork the project to your own github account. Clone the forked repository to your development machine.
25- Then run the following two commands to setup the project.
24+ Fork the project to your own GitHub account. Clone the forked repository to your development machine.
25+ Then run the following two commands to set up the project.
2626
2727 $ composer install
2828 $ tools/phive --home ./.phive install --trust-gpg-keys 4AA394086372C20A,31C7E470E2138192,8E730BA25823D8B5 --force-accept-unsigned
@@ -85,31 +85,31 @@ Test data should go in the `test/files` directory.
8585Add lots of test cases; they're cheap. Don't just test the obvious happy-path cases; test the
8686null case, where your feature does nothing (make sure it does!). Test edge cases, strange
8787inputs, missing inputs, non-ASCII characters, zeroes, and nils. Knowing what you know
88- about your implementation, what inputs and cases might possibly cause it to break? Test those.
88+ about your implementation, what inputs and cases might cause it to break? Test those.
8989
9090Remember people are using ` CaptainHook ` in their daily development process
91- where their data, their privacy, and even their business could be at stake. Now, of course
91+ where their data, their privacy, and even their business could be at stake. Now, of course,
9292it's up to them to make sure that their programs are safe and correct; library maintainers
9393bear no responsibility for that. But we can at least ensure that the code is as reliable
9494and trustworthy as we can make it.
9595
9696## Style and formatting
9797
98- This is easy, just use the PSR12 coding standard.
98+ This is straightforward, use the PSR12 coding standard.
9999
100100Your code should pass ` phpstan ` and ` phpcs ` without errors
101101(and if you want to run other linters too, that would be excellent).
102102
103103# Documentation
104104
105105It doesn't matter if you write the greatest piece of code in the history of the world,
106- if no one knows it exists, or how to use it.
106+ if no one knows it exists or how to use it.
107107
108108## Write doc comments
109109
110110Any functions or methods you write should have useful documentation comments in the standard ` PHPDoc `
111111format. Specifically, they should say what inputs the function takes, what it does (in detail),
112- and what outputs it returns. If it returns an error value or throw an exception,
112+ and what outputs it returns. If it returns an error value or throws an exception,
113113explain under what circumstances this happens.
114114
115115## Update the docs
@@ -163,17 +163,17 @@ but responding to code reviews is also a skilled task.
163163
164164If you find yourself reacting emotionally, take a break. Go walk in the woods for a while, or play
165165with a laughing child. When you come back to the code, approach it as though it were someone else's,
166- not your own, and ask yourself seriously whether or not the reviewer _ has a point_ .
166+ not your own, and ask yourself seriously whether the reviewer _ has a point_ .
167167
168- If you genuinely think the reviewer has just misunderstood something, or made a mistake,
168+ If you genuinely think the reviewer has just misunderstood something or made a mistake,
169169try to clarify the issue. Ask questions, don't make accusations. Remember that every project
170170has a certain way of doing things, which may not be your way. It's polite to go along with these
171171practices and conventions.
172172
173- You may feel as though you're doing the project maintainer a favour by contributing, as indeed you are,
173+ You may feel as though you're doing the project maintainer a favor by contributing, as indeed you are,
174174but an open source project is like somebody's home. They're used to living there, they probably
175175like it the way it is, and they don't always respond well to strangers marching in and rearranging the furniture.
176- Be considerate, and be willing to listen and make changes.
176+ Be considerate and be willing to listen and make changes.
177177
178178## This may take a while
179179
0 commit comments