feat: add REST-based MFA builtin spec for GitHub orgs#77
Open
deobieta wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gabriel De Obieta <deobieta@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deobieta The full list of commands accepted by this bot can be found here. DetailsNeeds approval from a repository administrator.Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
specs/github/mfa-rest.yaml, a REST-based alternative to the existing GraphQLmfa.yamlspec for checking MFA status in GitHub orgs.orgs/${ORG}/members?filter=2fa_disabledvia REST APIhttp://github.com/carabiner-dev/snappy/specs/github/mfa-rest.yamlWhy not the existing GraphQL mfa.yaml
The GraphQL
mfa.yamluses thehasTwoFactorEnabledfield onmembersWithRole, which requires elevated token permissions not typically available in CI GitHub App setups. The REST endpointorgs/{ORG}/members?filter=2fa_disabledachieves the same check with standardread:orgscope, making it broadly compatible with GitHub App tokens used in CI pipelines.