eslint

Author: dgrelaud

lib/hlc.js

@@ -99,12 +99,12 @@ function create () {
 /**
  * Only for testing purposes
  */
-function _reset() {
+function _reset () {
   highestRemoteHLC = 0;
   counter = 0;
 }
 
-function getClockDriftMs() {
+function getClockDriftMs () {
   return toTimestamp(clockDriftHLC);
 }
 

lib/index.js

@@ -140,7 +140,7 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
         return;
       }
       db.backup(_backupFileName, {
-        progress({ totalPages: t, remainingPages: r }) {
+        progress ({ totalPages: t, remainingPages: r }) {
           const _progress = ((t - r) / t * 100).toFixed(1);
           debug('database backup progress: %s%', _progress);
           eventEmitter.emit('backup:progress', trigger, _backupFileName, _progress);
@@ -292,13 +292,13 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
     _getLastPatchInfo.push(_generateGetLastPatchInfoQuery('pending_patches'));
     _getPatchFromColumn.push(_generateGetPatchFromPendingTableQuery());
     // Get all tables ending with _patches except pending_patches
-    const _patchTables = db.prepare(`SELECT name FROM sqlite_master WHERE type='table' AND name LIKE '%_patches' AND name != 'pending_patches'`).all();
+    const _patchTables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name LIKE '%_patches' AND name != 'pending_patches'").all();
     // Generate merge patches query plan for each table
     for (const table of _patchTables) {
       const _tableName = table.name.slice(0, -8); // Remove '_patches' suffix
       try {
         // Check if index exists on _patchedAt column
-        const _indexExists = db.prepare(`SELECT 1 FROM sqlite_master WHERE type='index' AND tbl_name=? AND sql LIKE '%_patchedAt%'`).get([table.name]);
+        const _indexExists = db.prepare("SELECT 1 FROM sqlite_master WHERE type='index' AND tbl_name=? AND sql LIKE '%_patchedAt%'").get([table.name]);
         if (!_indexExists) {
           console.warn(`Warning: Table ${table.name} is missing an index on _patchedAt column which may impact performance`);
         }
@@ -379,7 +379,7 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
    *
    * This function applies migration scripts (up or down) as needed to synchronize the database schema to the target version
    * as determined by the length of the `appMigrations` array. If the target version is less than the current database version,
-   * down migrations are executed in reverse order. If the target version is greater than the current version, up migrations are 
+   * down migrations are executed in reverse order. If the target version is greater than the current version, up migrations are
    * applied in order. Migration changes are transactional.
    *
    * @param {Array<{ up: string, down: string }>} appMigrations Array of migration objects describing the changes required for each version.
@@ -439,8 +439,8 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
    * Detects missing patches since a given timestamp.
    *
    * This function analyzes the database for missing sequence IDs from a provided timestamp onward.
-   * For each peer that has missing patches, it optionally updates that peer's statistics and 
-   * sends a retransmission request for the missing sequence range to the peer, provided a socket 
+   * For each peer that has missing patches, it optionally updates that peer's statistics and
+   * sends a retransmission request for the missing sequence range to the peer, provided a socket
    * connection exists. Updates statistics for synchronized peers as well.
    *
    * TODO: Add test for case where peerSockets[peerId] does not exist but peerId exists in DB with missing patches.
@@ -530,7 +530,7 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
    * @param {Object} rowPatch - The row data to use as the delta for the generated patch.
    * @param {function(Error|null, string=):void} [callback] - Optional callback invoked with error or the session token.
    */
-  function upsert(tableName, rowPatch, callback) {
+  function upsert (tableName, rowPatch, callback) {
     if (!dbVersion) {
       return callback(new Error('Database version is not set'));
     }
@@ -612,9 +612,9 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
   /**
    * Handles patches received from connected peers.
    *
-   * This function processes an incoming patch message from a remote peer. 
-   * It ignores self-generated patches, handles version mismatches by storing 
-   * incompatible patches in the pending_patches table, and applies valid patches 
+   * This function processes an incoming patch message from a remote peer.
+   * It ignores self-generated patches, handles version mismatches by storing
+   * incompatible patches in the pending_patches table, and applies valid patches
    * to the relevant table. Patch application is debounced to batch updates.
    *
    * @param {Object} patch - The patch object received from a remote peer.
@@ -623,7 +623,7 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
    *   @param {string} patch.tab - The table name to which the patch applies.
    *   @param {number} patch.at - The timestamp when the patch was created.
    */
-  function _onPatchReceivedFromPeers(patch) {
+  function _onPatchReceivedFromPeers (patch) {
     try {
       if (parseInt(patch.peer, 10) === myPeerId) {
         debug('Received patch from myself. Ignore it.');
@@ -820,7 +820,7 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
       _peerStat[LAST_SEQUENCE_ID] = msg.seq;
       _peerStat[LAST_PATCH_AT_TIMESTAMP] = msg.at;
     }
-    // Otherwise, it's an old packet, or a ping (same sequence), if so do nothing. 
+    // Otherwise, it's an old packet, or a ping (same sequence), if so do nothing.
     // (Sequences can never go backward. If we receive a packet with a sequence less than the guaranteed one, we can ignore it—a double resend.)
   }
 
@@ -918,7 +918,7 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
    * TODO: Return an error if the request is too old (patch table has been cleaned up)?
    */
   function _onRequestForMissingPatchFromPeers (msg) {
-    let _missingPatch = [];
+    let _missingPatch;
     try {
       _missingPatch = globalStatements.getPatchFromColumn(msg.peer, msg.minSeq, msg.maxSeq);
     }
@@ -1012,9 +1012,9 @@ const SQLiteOnSteroid = (db, myPeerId = null, options) => {
   /**
    * Handles synchronization status update for a peer.
    *
-   * This function is called when a peer is considered synced, i.e., when it has received 
+   * This function is called when a peer is considered synced, i.e., when it has received
    * the last contiguous sequence for that peer. When a peer becomes synced
-   * for the first time, it is removed from the `peerStartedNotSynced` set and 
+   * for the first time, it is removed from the `peerStartedNotSynced` set and
    * the 'synced' event is emitted for that peer.
    *
    * @param {number|string} peerId - ID of the peer that is now synced. May be a string if from a for-in loop.

test/test.global.js

@@ -1,9 +1,6 @@
 const assert = require('assert');
 const SQLiteOnSteroid = require('../lib/index.js');
-const path = require('path');
-const fs = require('fs');
 const Database  = require('better-sqlite3');
-const debug = require('debug');
 const EventEmitter = require('events');
 const { simplifyStats } = require('./helper.js');
 const hlc = require('../lib/hlc.js');

test/test.main.js

@@ -4,8 +4,7 @@ const hlc = require('../lib/hlc.js');
 const path = require('path');
 const fs = require('fs');
 const Database  = require('better-sqlite3');
-const debug = require('debug');
-const { simplifyStats, removeLastTimestampInStats } = require('./helper.js');
+const { removeLastTimestampInStats } = require('./helper.js');
 const MockDate = require('mockdate');
 
 describe('main', function () {
@@ -657,15 +656,15 @@ describe('main', function () {
         app._onPatchReceivedFromPeers(_rowPatch1);
       }
       catch (e) {
-        assert.fail('app._onPatchReceivedFromPeers should not throw an error');
+        assert.fail(e);
       }
       try {
-        app.upsert('testA', { id : 1, tenantId : ['Bad data'], name : '2d' }, (err) => {
+        app.upsert('testA', { id : 1, tenantId : ['Bad data'], name : '2d' }, () => {
           done();
         });
       }
       catch (e) {
-        assert.fail('app.upsert should not throw an error');
+        assert.fail(e);
       }
     });
 
@@ -716,14 +715,14 @@ describe('main', function () {
         _patchedAt   : hlc.from(_constantTimestamp),
         _peerId      : 20,
         _sequenceId  : 1,
-        delta        : '{\"20\":[0,0]}',
+        delta        : '{"20":[0,0]}',
         patchVersion : 1,
         tableName    : '_'
       }, {
         _patchedAt   : hlc.from(_constantTimestamp),
         _peerId      : 10,
         _sequenceId  : 20,
-        delta        : '{\"20\":[1,1]}',
+        delta        : '{"20":[1,1]}',
         patchVersion : 2,
         tableName    : '_'
       }]);
@@ -1088,7 +1087,7 @@ describe('main', function () {
           app._onRequestForMissingPatchFromPeers({ type : 30 /* MISSING_PATCH */, peer : 2, minSeq : 2, maxSeq : 2, forPeer : 2 }); // missing A
         }
         catch (e) {
-          assert.fail('app._onRequestForMissingPatchFromPeers should not throw an error');
+          assert.fail(e);
         }
         done();
       }, patchApplyDelayMs);
@@ -1288,7 +1287,7 @@ describe('main', function () {
     it('should backup the database', function (done) {
       // define a custom function to observe the provided backup file path and ensure it's called
       let _capturedFileName;
-      function databaseBackupAbsolutePathFn(trigger, cb) {
+      function databaseBackupAbsolutePathFn (trigger, cb) {
         const _date = new Date().toISOString().slice(0, 19).replace(/:/g, '-') + 'Z';
         _capturedFileName = path.join(_testDir, `${trigger}-${_date}.sqlite`);
         cb(_capturedFileName);
@@ -1313,11 +1312,11 @@ describe('main', function () {
       });
     });
     it('should not create a backup if the function does not return a path for backup', function (done) {
-      function databaseBackupAbsolutePathFn(trigger, cb) {
+      function databaseBackupAbsolutePathFn (trigger, cb) {
         cb(null);
       }
       const _app = SQLiteOnSteroid(db, 1, { databaseBackupAbsolutePathFn });
-      _app.backupDatabase('scheduled', function (err, trigger, backupFileName) {
+      _app.backupDatabase('scheduled', function (err) {
         try {
           assert.strictEqual(err.message, 'No backup file name for scheduled trigger');
           assert.strictEqual(fs.existsSync(_testDir), true, 'Backup directory should exist');
@@ -1333,7 +1332,7 @@ describe('main', function () {
       let gotCompleted = false;
       let gotProgress = false;
       // Use a real absolute path fn
-      function databaseBackupAbsolutePathFn(trigger, cb) {
+      function databaseBackupAbsolutePathFn (trigger, cb) {
         const _date = new Date().toISOString().slice(0, 19).replace(/:/g, '-') + 'Z';
         cb(path.join(_testDir, `${trigger}-${_date}.sqlite`));
       }
@@ -1367,7 +1366,7 @@ describe('main', function () {
       // No callback to backupDatabase, so events must fire
       _app.backupDatabase('scheduled');
       // Helper to call done when both events are received
-      function finishTestIfReady() {
+      function finishTestIfReady () {
         if (gotCompleted && gotProgress) {
           done();
         }

test/test.migrate.js

@@ -1,9 +1,6 @@
 const assert = require('assert');
 const SQLiteOnSteroid = require('../lib/index.js');
-const path = require('path');
-const fs = require('fs');
 const Database  = require('better-sqlite3');
-const debug = require('debug');
 
 describe('migrate', function () {
   let db, app;