fix: cache stampede and remove verifySyncStatus from block endpoints#766
Closed
Sotatek-HenryDo wants to merge 2 commits into
Closed
fix: cache stampede and remove verifySyncStatus from block endpoints#766Sotatek-HenryDo wants to merge 2 commits into
Sotatek-HenryDo wants to merge 2 commits into
Conversation
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a cache stampede issue on
/network/statusby addingsync = trueto the@Cacheableannotation ongetSyncStatus(),ensuring that only one thread queries the database on a cache miss while concurrent requests wait and reuse the cached result. To eliminate unnecessary cache checks on hot paths, we removed theverifySyncStatus()guard from the/blockand/block/transactionendpoints inBlockApiImpl.java. Additionally, the concurrency test was hardened by using aCountDownLatchto trigger true simultaneous requests, adding a 5-second timeout to prevent CI deadlocks, and checking the returned values for consistency.