Skip to content

Commit 418ef62

Browse files
lucaslylclaude
andauthored
Catalog live tests break ember-tsc after command-service → tool-service rename (#650)
linear: https://linear.app/cardstack/issue/ECO-520/catalog-live-tests-break-ember-tsc-after-command-service-tool-service ## summary: Host renamed the `command-service` service to `tool-service` (boxel 2dd31de2c8). The runtime `legacy-tool-service-alias` keeps the old lookup key working at runtime, but only `'tool-service'` is declared in the `@ember/service` Registry type, so `getService('command-service')` type-checks as `object | undefined` and fails `ember-tsc --noEmit` in the Lint Catalog job. Look the service up by its current registry key in the catalog live tests. The service still exposes `commandContext`, so no other change is needed. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 0d14059 commit 418ef62

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

tests/live/catalog-app/commands.test.gts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export function runTests() {
125125
listingUrl: string,
126126
realm: string,
127127
) {
128-
const commandService = getService('command-service');
128+
const commandService = getService('tool-service');
129129
const store = getService('store');
130130

131131
const command = new commandClass(commandService.commandContext);
@@ -265,7 +265,7 @@ export function runTests() {
265265
]);
266266
skip('card listing with single dependency module', async function (assert) {
267267
const cardId = mockCatalogURL + 'author/Author/example';
268-
const commandService = getService('command-service');
268+
const commandService = getService('tool-service');
269269
const command = new ListingCreateCommand(
270270
commandService.commandContext,
271271
);
@@ -359,7 +359,7 @@ export function runTests() {
359359

360360
skip('listing will only create specs with recognised imports from realms it can read from', async function (assert) {
361361
const cardId = mockCatalogURL + 'UnrecognisedImports/example';
362-
const commandService = getService('command-service');
362+
const commandService = getService('tool-service');
363363
const command = new ListingCreateCommand(
364364
commandService.commandContext,
365365
);
@@ -403,7 +403,7 @@ export function runTests() {
403403

404404
skip('app listing', async function (assert) {
405405
const cardId = mockCatalogURL + 'blog-app/BlogApp/example';
406-
const commandService = getService('command-service');
406+
const commandService = getService('tool-service');
407407
const command = new ListingCreateCommand(
408408
commandService.commandContext,
409409
);
@@ -632,7 +632,7 @@ export function runTests() {
632632

633633
skip('after create command, listing card opens on stack in interact mode', async function (assert) {
634634
const cardId = mockCatalogURL + 'author/Author/example';
635-
const commandService = getService('command-service');
635+
const commandService = getService('tool-service');
636636
const command = new ListingCreateCommand(
637637
commandService.commandContext,
638638
);

tests/live/catalog-app/listing-create.test.gts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export function runTests() {
233233
]);
234234
skip('card listing with single dependency module', async function (assert) {
235235
const cardId = mockCatalogURL + 'author/Author/example';
236-
const commandService = getService('command-service');
236+
const commandService = getService('tool-service');
237237
const command = new ListingCreateCommand(
238238
commandService.commandContext,
239239
);
@@ -327,7 +327,7 @@ export function runTests() {
327327

328328
skip('listing will only create specs with recognised imports from realms it can read from', async function (assert) {
329329
const cardId = mockCatalogURL + 'UnrecognisedImports/example';
330-
const commandService = getService('command-service');
330+
const commandService = getService('tool-service');
331331
const command = new ListingCreateCommand(
332332
commandService.commandContext,
333333
);
@@ -371,7 +371,7 @@ export function runTests() {
371371

372372
skip('app listing', async function (assert) {
373373
const cardId = mockCatalogURL + 'blog-app/BlogApp/example';
374-
const commandService = getService('command-service');
374+
const commandService = getService('tool-service');
375375
const command = new ListingCreateCommand(
376376
commandService.commandContext,
377377
);
@@ -600,7 +600,7 @@ export function runTests() {
600600

601601
skip('after create command, listing card opens on stack in interact mode', async function (assert) {
602602
const cardId = mockCatalogURL + 'author/Author/example';
603-
const commandService = getService('command-service');
603+
const commandService = getService('tool-service');
604604
const command = new ListingCreateCommand(
605605
commandService.commandContext,
606606
);

tests/live/catalog-app/listing-install.test.gts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export function runTests() {
8484
listingUrl: string,
8585
realm: string,
8686
) {
87-
const commandService = getService('command-service');
87+
const commandService = getService('tool-service');
8888
const store = getService('store');
8989

9090
const command = new commandClass(commandService.commandContext);

tests/live/catalog-app/listing-remix.test.gts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export function runTests() {
8787
listingUrl: string,
8888
realm: string,
8989
) {
90-
const commandService = getService('command-service');
90+
const commandService = getService('tool-service');
9191
const store = getService('store');
9292

9393
const command = new commandClass(commandService.commandContext);

tests/live/catalog-app/listing-use.test.gts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export function runTests() {
8080
listingUrl: string,
8181
realm: string,
8282
) {
83-
const commandService = getService('command-service');
83+
const commandService = getService('tool-service');
8484
const store = getService('store');
8585

8686
const command = new commandClass(commandService.commandContext);

0 commit comments

Comments
 (0)