Skip to content

Commit ff84e9d

Browse files
authored
Merge pull request #5120 from cardstack/cs-11331-tag-grey-peek-and-nudge
2 parents 31f9da7 + 7893dec commit ff84e9d

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

packages/host/app/components/adorn/adorn-label.gts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ const AdornLabel: TemplateOnlyComponent<AdornLabelSignature> = <template>
6969
border-radius: 0.3125rem 0 0 0.3125rem;
7070
clip-path: polygon(0 0, calc(100% - 0.8125rem) 0, 100% 100%, 0 100%);
7171
z-index: 1;
72-
filter: drop-shadow(0 0.3125rem 0.5rem rgba(0, 0, 0, 0.2));
7372
}
7473
/* Mirrored polygon when the label flips below the card so the
7574
slope still points toward the card edge. */

packages/host/app/modifiers/position-adorn-label.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ export function makePositionAdornLabel(
116116
anchorLeftX = cardRect.left - 4;
117117
label.style.maxWidth = 'max-content';
118118
}
119-
// When flipped below, overlap the card by 2px so the flag's wide
120-
// top edge tucks under the bottom outline stroke and reads as
121-
// attached. (Anchoring it 2px below the card instead left a
122-
// visible gap under the stroke.)
119+
// When flipped below, sit the flag's top edge flush with the card's
120+
// bottom edge — no overlap into the card (any overlap reads as the tag
121+
// riding too high over the edge), and no gap (its z-index keeps it
122+
// above the selection outline stroke, so it still reads as attached).
123123
let anchorTopY =
124-
side === 'top' ? cardRect.top - labelHeight - 2 : cardRect.bottom - 2;
124+
side === 'top' ? cardRect.top - labelHeight - 2 : cardRect.bottom;
125125

126126
// The label's anchor positions (anchorLeftX, anchorTopY) are in
127127
// viewport coordinates. With `position: absolute`, the inline

0 commit comments

Comments
 (0)