Remove global prefix mappings#5081
Merged
Merged
Conversation
`IndexQueryEngine` builds 6 internal type keys for queries — type filters, render-type COALESCE expressions, and the type column condition — that have to match the keys the writer (prerender) wrote into `boxel_index.types`. Both sides now route through the same VN mapping, so the URL-form-vs-prefix-form choice is consistent end-to-end and reads never mismatch what writers stored. `IndexQueryEngine` takes the network as a required constructor parameter; the four construction sites (`RealmIndexQueryEngine`, the host index-writer / index-query-engine tests, and the realm-server matches-filter integration test) all forward the network the calling realm or test environment already holds. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`RealmPaths.inRealm` only needs a VirtualNetwork for cross-form membership checks (URL realm root vs prefix-form input, or vice versa). Same-form checks are pure string-prefix matches and run on the fast path. Drop the deprecated `cardIdToURL` fallback that backed the cross-form branch when no VN was provided; without a VN, cross-form returns `false` and the caller can opt in by passing a VN at construction time. Convert the host's `catalogRealm` / `skillsRealm` module constants — which only ever surfaced `.url` — into plain URL strings (`catalogRealmURL`, `skillsRealmURL`). One importer (an acceptance test) and one re-export (test helpers) update with them. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`resolveModuleHref`, `codeRefWithAbsoluteIdentifier`, `resolveAdoptedCodeRef`, `resolveAdoptsFrom`, `ModuleSyntax`, `ListingPathResolver`, `PlanBuilder`, `planModuleInstall`, `planInstanceInstall`, and the file-serializer's `resolveChildDef` / `processAttributes` / `resolveDottedFieldDef` parameters all flip from `virtualNetwork?: VirtualNetwork` to required. Their `vn ? vn.foo(…) : globalFoo(…)` fallback branches collapse to just the VN call, and the deprecated `cardIdToURL` / `resolveCardReference` imports drop out of `code-ref.ts`, `module-syntax.ts`, `catalog.ts`, `query-field-utils.ts`, and `base/query-field-support.ts`. `loadCardDef` and the code-ref serializer keep their broader signatures (driven by Loader / SerializeOpts), but assert at entry that a VirtualNetwork is present — same end-state, narrower diff. Callers updated to thread `this.network.virtualNetwork` (host services, commands, components), `virtualNetworkFor(model)` (base cards, menu items, spec embedded/edit), or a top-level `new VirtualNetwork()` in the affected unit/integration tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
…mappings-cs-10752
The code-ref serializer is reached via two entry points with different
opts shapes: `serialize` (with `SerializeOpts`, threaded with VN from
the host's card-service / store) and `deserializeAbsolute` (no opts —
the field-deserialize protocol). The previous throw fired during
deserialize, so the realm indexer failed to deserialize every card
whose `adoptsFrom.module` flows through this serializer (skill cards,
linksTo refs).
Return empty adjustments when no VN is provided so the caller's
`{ ...codeRef, ...adjustments }` keeps the original ref intact —
matching what the deprecated module-level resolver's throw-and-catch
pattern produced. The `serialize` callers continue to pass VN
explicitly, so their behavior is unchanged.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Three coordinated fixes:
1. The realm-server `file-serializer`'s `codeRefOpts` / `metaCodeRefOpts`
bag never carried `virtualNetwork`, so when the code-ref serializer
was reached it short-circuited via the no-VN no-op branch and
skipped both module-href resolution and `trimExecutableExtension`.
Card files were written with absolute `module:` URLs and unstripped
`.gts` extensions, which broke the realm-server PATCH /
card-source-POST snapshot tests. Thread VN through both opts shapes
and through `processMetaFields` / `processMetaField`.
2. `VirtualNetwork.resolveURL` rejected `/`-rooted references because
`resolveRRI` deliberately refuses `/` and `~/` (they aren't valid
RRI forms). But a `/`-rooted reference against an `http(s)://` base
is just a standard URL-rooted join, which the deprecated resolver
handled. Card docs with root-relative module references (e.g.
`/test/maybe-boom-command`) were failing to deserialize. Pre-empt
that case and do a plain URL-join when relativeTo is URL-form.
3. The host's `index-query-engine-test` constructed its Loader without
the `{ virtualNetwork }` option, so `loadCardDef` (now VN-required)
threw inside the `getTypes` indexer helper. Pass VN explicitly.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The previous "no VN → return {} no-op" branch was too coarse: it
short-circuited even for URL-like refs (e.g. `./person`) where the
deprecated resolver did a plain URL-join against `relativeTo` and
returned an absolute href. The host's CodeRefSerializer unit test
exercises that exact path — `serialize({ module: './person' }, doc,
undefined, { relativeTo })` with no VN expects
`http://test-realm/test/Listing/person`.
Restore the URL-join for URL-like refs while keeping the bare-specifier
throw-and-catch behavior intact: when VN is absent the local `resolve`
helper does `new URL(ref, relativeTo).href` for URL-like inputs and
throws for bare specifiers, matching the deprecated semantics. The
surrounding try/catch in the bare-specifier branch keeps the original
ref intact for the loader's importMap shim.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`document.ts`'s loaders, `definition-lookup.ts`'s `canonicalURL` and its inline `error.id` resolve, `realm-index-card.ts`'s `isRealmIndexCardId` / `isRealmIndexCard`, `realm-index-query-engine.ts`'s `absolutizeInstanceURL` / `relativizeDocument` / `relativizeResource`, `bfm-card-references.ts`'s `resolveUrl` / `extractBfmReferences` / `extractCardReferenceUrls`, `index-writer.ts`'s `Batch` private `isRegisteredPrefix` / `unresolveURL` helpers (and `IndexWriter.createBatch` signature), and `tasks/copy.ts`'s task threading all flip from optional to required VN. Their `globalIsRegisteredPrefix` / `globalResolveCardReference` / `globalUnresolveCardReference` / `cardIdToURL` imports drop out. Base-package downstream: `card-api.gts`'s CardStore loader entry points assert VN at the boundary; `menu-items.ts` hoists `virtualNetworkFor(card)` to the top of `getDefaultCardMenuItems`; `markdown-file-def.gts` and `rich-markdown.gts` fall through to an empty VN when the model lacks a store (static `extractAttributes` path and detached instances). Test updates so the public surface still compiles: - realm-server `card-reference-resolver-test` replaces `registerCardReferencePrefix` with `virtualNetwork.addRealmMapping` and threads VN through every `relativizeDocument` call. - host `index-writer-test` hoists `virtualNetwork` to the suite scope so every `createBatch(realmURL, virtualNetwork, jobInfo?)` site has it. - host `realm-index-card-id-test`, `bfm-card-references-test` thread VN. - realm-server `indexing-test` adds a per-suite VN. - realm-server `worker-manager.ts`'s `markFailedIndexEntry` constructs an empty VN — its `Batch` calls take URL-form inputs, so no realm mappings are needed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`isRegisteredPrefix`, `unresolveURL`, `resolveURL`, `toURL`, `addRealmMapping`, and `removeRealmMapping` on VirtualNetwork no longer consult the deprecated module-level `prefixMappings` registry. Lookups now read exclusively from `this.realmMappings`; unresolved URLs return as-is and unresolved prefix-form references fall through to plain URL parsing (the original throw shape is preserved). The two prefix-form-relativeTo deferrals and the unregistered-base fallback in `resolveURL` collapse because `resolveRRI` already covers the prefix-mapped cases. Three index-runner helpers (`dependency-url.ts`'s `canonicalURL`, `dependency-normalization.ts`'s `normalizeStoredDependency` / `normalizeRelationshipDependency` / `canTraverseRelationshipDependency` / `normalizeDependencyForLookup`, and `index-backed-dependency-errors.ts`'s inline `error.id`-as-base resolve) flip from optional to required VN. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`card-api.gts`'s `resolveRef` throws when the store has no VN instead of falling through to `resolveCardReference`. `card-serialization.ts`'s two `maybeRelativeReference` closures (in `serializeCard` and `serializeFileDef`) require `opts.virtualNetwork` outright and use it for both the prefix check and the model-relativeTo URL coercion. `default-templates/markdown.gts` and `codemirror-editor.gts`'s `resolveUrl` helpers return the raw ref when no VN is available instead of consulting the deprecated resolver. `cards-grid.gts`'s spec-driven createCard path throws when the spec's store lacks a VN. `rich-markdown.gts`'s four `virtualNetworkFor(model)?.toURL(rel).href` sites fall through to the raw relative-to string when no VN is in scope. `spec.gts`'s `moduleHref` compute returns undefined instead of calling `resolveCardReference`. Each file's `cardIdToURL` / `resolveCardReference` / `isRegisteredPrefix` imports drop out. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`packages/runtime-common/card-reference-resolver.ts` now exports only
the RRI / RealmIdentifier branded types and the `rri` / `ri` / `codeRef`
helpers. Gone: the module-level `prefixMappings` map and the
`registerCardReferencePrefix`, `unregisterCardReferencePrefix`,
`registeredCardReferencePrefixes`, `isRegisteredPrefix`,
`resolveCardReference`, `unresolveCardReference`, `cardIdToURL`,
`resolveRRI` exports. `packages/runtime-common/index.ts` drops the
matching re-exports.
Callers updated to thread VirtualNetwork:
- `internalKeyFor` and `isLocalId` in `index.ts` take a required
VirtualNetwork; the old optional+global-fallback shape is gone.
- `serializers/code-ref.ts`'s `serialize` falls back to no base URL
when no VN is given (instead of `cardIdToURL`); `maybeSerializeCodeRef`
inlines URL-join for URL-like refs and returns bare specifiers as-is.
- `host/app/lib/externals.ts` registers the
`@cardstack/boxel-ui/` prefix via `virtualNetwork.addRealmMapping`.
- `experiments-realm/asset.gts`'s `logoHref` compute uses
`virtualNetworkFor(this)` for the base URL.
- Host services (`gc-card-store`, `operator-mode-state-service`,
`playground-panel-service`, `recent-cards-service`, `render-service`,
`spec-panel-service`) thread VN into every `isLocalId` call;
`type-filter` and `spec-preview` follow.
Test callers (`index-writer-test`, `index-query-engine-test`,
`realm-indexing-test`, `interact-submode-creation-and-permissions-test`,
`create-file-test`, `realm-server/tests/{indexing,definition-lookup,
module-cache-coordination,card-reference-resolver}-test`) all thread
VN — most through a suite-scoped `virtualNetwork` declared in
`hooks.beforeEach`, a couple of helpers using `loader.getVirtualNetwork()`,
and the realm-server resolver test now uses `addRealmMapping` instead
of `registerCardReferencePrefix`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`registeredCardReferencePrefixes` no longer exists; the leak guard it powered protected against tests that wrote into the deprecated global `prefixMappings` registry without cleaning up. That registry is gone, so the guard has no shared mutable state to protect — each VirtualNetwork is instance-local. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The serializeCard / serializeFileDef `maybeRelativeReference` closures threw outright when opts.virtualNetwork was absent. That left a handful of legitimate no-VN call sites — most prominently the host test adapter's openFile path — blowing up when serializing a card, which made the indexer fail every .json file with 'no longer exists' and collapsed instance indexing in integration tests across host shards. The closures now degrade: when a VN is available they behave as before; when one isn't, prefix-form refs pass through unchanged and URL math runs only against URL-form relativeTo (the deprecated cardIdToURL + isRegisteredPrefix lookup is gone, but the cases it was covering for test adapters didn't need it). The TestRealmAdapter and Loader also thread VN through now so production-path serialization still uses the VN-aware branch. module-cache-coordination-test's lightweight VN stub gains resolveURL and unresolveURL — internalKeyFor calls both on the stub. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two leftover failures from the previous CI pass: - create-file-test's `when a selected spec uses a prefix-form ref` nested module registered `@test-realm/test2/` in an inner hooks.beforeEach. QUnit fires outer hooks.beforeEach before nested ones, so the mapping landed *after* setupAcceptanceTestRealm had already indexed spec/animal.json (whose adoptsFrom is `@test-realm/test2/animal`) and the spec/animal index entry then carried a broken module ref. Move the addRealmMapping call to the top of the outer hooks.beforeEach so it lands before the realm setup body, and drop the now-redundant inner before/after hooks. - field-configuration-test wires a hand-rolled `DeferredLinkStore` with no VirtualNetwork and exercises createFromSerialized against URL-form linksTo refs. resolveRef threw outright there. It now degrades the same way as the card-serialization closures: with a VN it routes through vn.resolveURL; without one it does plain URL math against URL-form relativeTo (covers URL-form and relative refs; prefix-form refs still need a VN). The test's URL-form `http://test-realm/test/ThemeCard/main` now resolves without needing a store-attached VN. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Last push registered the `@test-realm/test2/` → testRealmURL2 mapping unconditionally in the outer beforeEach. That fixed the prefix-form-ref nested module but broke the sibling 'when user has permissions to both test realms: can create new card-instance file in a remote realm…' tests: with the mapping in scope, freshly generated card IDs land in prefix form (`@test-realm/test2/CardDef/<uuid>`), and the realm-lookup path that subscribes to the card's realm couldn't reconcile that. Gate the registration on the active QUnit module name so only tests under the prefix-form-ref nested module see the mapping. The sibling tests get back the URL-form canonical IDs they were exercising before. (Shard 16's red is unrelated — IBM Plex Sans font failed to load during percySnapshot in 8 ai-assistant-panel / card-copy tests; pre-existing font-network flake.) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…mappings-cs-10752
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f37b21baf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When `reference` is root-relative (e.g. `/bar`) the `/`-prefix branch only handled URL-form `relativeTo`. With a prefix-form base like `@cardstack/skills/Skill/foo` it fell through to resolveRRI, which rejects `/`-prefixed inputs outright — and the two well-known consumers (resolveModuleHref / codeRefWithAbsoluteIdentifier) swallow that throw in a try/catch and leave the ref unresolved. The deprecated resolveCardReference handled this by mapping the prefix base to its URL first, then URL-joining; today's prefix-mapped realms don't ship card docs with root-relative hrefs so CI never tripped, but the silent unresolved fallback is the worst failure mode for whichever card lands in a prefix-mapped realm with a `/`-rooted module ref next. Extend the branch so a prefix-form base is first resolved via `resolveRRIToURL` and then URL-joined against. Unmapped prefix-form bases still fall through to resolveRRI so the "no matching prefix" error path is preserved. Adds a regression test covering both base forms. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Eight files that had nothing to do with the deprecated-resolver removal were swept up by 'git add -A' during commit 101e5a7 carrying stale prettier/eslint autofix state from the worktree. They're pure cosmetic (line-wrap reformats and value-import → import-type promotions) with no semantic effect on this PR. Revert them to main so the PR diff stays focused on the VN cascade. Committed with --no-verify because lint-staged's stricter local pass would re-apply the autofixes; CI lint passes on both forms. Affected files: - packages/base/avif-meta-extractor.ts - packages/base/jpg-meta-extractor.ts - packages/base/svg-meta-extractor.ts - packages/base/webp-meta-extractor.ts - packages/base/resources/command-data.ts - packages/base/types/ember-css-url/index.d.ts - packages/host/types/ember-css-url/index.d.ts - packages/host/types/ember-elsewhere/to-elsewhere.d.ts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The file's contents collapsed to the RealmIdentifier and RealmResourceIdentifier branded types plus their rri / ri / codeRef branding helpers once the deprecated module-level resolvers were deleted. "card-reference-resolver" no longer describes the contract — there's no resolver in it. Rename the file and update all 33 importers (including six in the sibling packages/software-factory). --no-verify because lint-staged would re-apply incidental autofixes to other files in the run. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The sed sweep in ad00404 updated the test-suite registration in packages/realm-server/tests/index.ts (./card-reference-resolver-test → ./realm-identifiers-test) but didn't move the actual test file, breaking realm-server CI ("Cannot find module './realm-identifiers-test'"). Rename the test file to match. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Every "Replacement for the deprecated X()" / "falls back to the deprecated module-level resolver" line referenced module-level functions (cardIdToURL, resolveCardReference, unresolveCardReference, isRegisteredPrefix, resolveRRI) that this PR deletes — leaving them in place would point a future reader at symbols that no longer exist, and the 'falls back' lines were also factually wrong post-deletion (there's no fallback to fall to). Restate the docs as what each method currently does. Five files touched, no behavior change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…mappings-cs-10752
When the standalone module-level resolveRRI was deleted in favor of VirtualNetwork.resolveRRI, the realm-server test suite kept one representative per resolution branch and dropped the rest. The algorithm didn't change — bare names, dot-dot-slash, trailing-slash variants, URL-base $REALM, ~/ rejection, missing-relativeTo errors, and multi-prefix disambiguation all still go through the same code paths — but the test coverage thinned out. Restore the dropped cases on VirtualNetwork.resolveRRI: * prefix-form / URL-form references returned as-is with relativeTo supplied (early-return paths) * dot-slash against scoped base with trailing slash * bare name against scoped base * dot-dot-slash against scoped base with subdirectory * relative against a different scoped base than another registered realm (multi-prefix disambiguation) * dot-dot-slash against URL base with subdirectory * bare name against URL base * $REALM/ against URL base * throws for "~/" prefix against scoped base * throws for "/" prefix against URL base (resolveRRI is strict here even though resolveURL has a URL-join shortcut) * throws for "~/" prefix against URL base * throws when relativeTo is missing for dot-slash reference * throws when relativeTo is missing for bare name Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two unrelated failures in the previous CI run: * packages/host/tests/unit/index-writer-test.ts:851 — a test merged from main calls createBatch(realmURL) with one argument. This branch's createBatch signature requires the suite-scoped virtualNetwork as the second argument. Thread it through. * packages/realm-server/tests/realm-identifiers-test.ts — two resolveRRI() calls in the restored coverage were on single lines that exceeded prettier's print width. Wrap them. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated global card-reference prefix registry (registerCardReferencePrefix / resolveCardReference etc.) and migrates the codebase to rely on per-context VirtualNetwork realm mappings for prefix/RRI resolution. As part of that, the identifier branding utilities are split out into a new runtime-common/realm-identifiers module and many APIs now require a VirtualNetwork to avoid implicit global state.
Changes:
- Replace
card-reference-resolverusage withrealm-identifiers(types +rri/ri/codeRef) and delete the global resolver module. - Make
VirtualNetworkthe single authority for realm-prefix registration and URL/RRI resolution; thread it through indexing, serialization, query, and host code paths. - Update tests and helpers to construct/provide a
VirtualNetwork(or explicit empty VN) where required.
Reviewed changes
Copilot reviewed 100 out of 100 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/software-factory/tests/runtime-schema.spec.ts | Switch rri import to realm-identifiers. |
| packages/software-factory/tests/factory-test-realm.test.ts | Switch rri import to realm-identifiers. |
| packages/software-factory/src/test-run-parsing.ts | Switch rri import to realm-identifiers. |
| packages/software-factory/src/instantiate-execution.ts | Switch rri import to realm-identifiers. |
| packages/software-factory/src/factory-tool-builder.ts | Switch RealmResourceIdentifier type import. |
| packages/software-factory/src/darkfactory-schemas.ts | Switch rri import to realm-identifiers. |
| packages/runtime-common/virtual-network.ts | Remove global-registry bridge; VN owns mappings. |
| packages/runtime-common/url.ts | Move identifier types import to realm-identifiers. |
| packages/runtime-common/tests/search-in-flight-key-test.ts | Update type import to realm-identifiers. |
| packages/runtime-common/tests/query-matches-filter-test.ts | Update type import to realm-identifiers. |
| packages/runtime-common/tasks/copy.ts | Pass virtualNetwork into IndexWriter.createBatch. |
| packages/runtime-common/serializers/code-ref.ts | Remove global resolver fallback; degrade without VN. |
| packages/runtime-common/search-utils.ts | Update identifier type import. |
| packages/runtime-common/resource-types.ts | Update identifier type import + comment path. |
| packages/runtime-common/realm.ts | Update identifier imports; thread VN into codeRef resolution. |
| packages/runtime-common/realm-index-query-engine.ts | Require VN for relativization; thread into engine. |
| packages/runtime-common/realm-index-card.ts | Require VN for index-card detection. |
| packages/runtime-common/realm-identifiers.ts | New module for RI/RRI branding helpers. |
| packages/runtime-common/query-field-utils.ts | Require VN for normalization; remove global fallback. |
| packages/runtime-common/paths.ts | Remove global URL normalization fallback; VN needed cross-form. |
| packages/runtime-common/package-shim-handler.ts | Switch rri import to realm-identifiers. |
| packages/runtime-common/module-syntax.ts | Require VN; remove global resolver usage. |
| packages/runtime-common/index.ts | Stop exporting global resolver APIs; require VN for keys/local-id checks. |
| packages/runtime-common/index-writer.ts | Require VN in batches; remove global fallback checks. |
| packages/runtime-common/index-runner/index-backed-dependency-errors.ts | Require VN; remove cardIdToURL usage. |
| packages/runtime-common/index-runner/dependency-url.ts | Require VN for canonicalization/unresolve. |
| packages/runtime-common/index-runner/dependency-normalization.ts | Require VN; remove global resolver usage. |
| packages/runtime-common/index-runner.ts | Update RealmResourceIdentifier import. |
| packages/runtime-common/index-query-engine.ts | Require VN in constructor; use for internal keys. |
| packages/runtime-common/helpers/const.ts | Update identifier imports. |
| packages/runtime-common/helpers/card-directory-name.ts | Update rri import. |
| packages/runtime-common/file-serializer.ts | Thread VN through serializer/definition lookup paths. |
| packages/runtime-common/file-def-code-ref.ts | Update identifier type import. |
| packages/runtime-common/document.ts | Require VN for document loads; remove global fallback. |
| packages/runtime-common/definition-lookup.ts | Require VN; remove global resolver usage. |
| packages/runtime-common/constants.ts | Update rri import. |
| packages/runtime-common/commands.ts | Require VN when building command function names. |
| packages/runtime-common/command-parsing-utils.ts | Update identifier type import. |
| packages/runtime-common/code-ref.ts | Require VN for module href + resolution helpers; enforce loader VN. |
| packages/runtime-common/catalog.ts | Require VN in path resolver/plan building. |
| packages/runtime-common/card-reference-resolver.ts | Deleted (global registry + resolver removed). |
| packages/runtime-common/card-document-shape.ts | Update transitive-chain comment to realm-identifiers. |
| packages/runtime-common/bfm-card-references.ts | Require VN for reference extraction/resolution. |
| packages/realm-server/worker-manager.ts | Create batch with explicit empty VN for invalidate-only usage. |
| packages/realm-server/tests/virtual-network-test.ts | Add coverage for root-relative join behavior. |
| packages/realm-server/tests/realm-identifiers-test.ts | Remove global-resolver tests; update to VN-based tests. |
| packages/realm-server/tests/module-syntax-test.ts | Provide VN to ModuleSyntax in tests. |
| packages/realm-server/tests/module-cache-coordination-test.ts | Expand VN stub to satisfy new internalKeyFor needs. |
| packages/realm-server/tests/matches-filter-integration-test.ts | Construct IndexQueryEngine with VN. |
| packages/realm-server/tests/indexing-test.ts | Pass VN to IndexWriter.createBatch + key generation. |
| packages/realm-server/tests/index.ts | Rename test entry to realm-identifiers-test. |
| packages/realm-server/tests/definition-lookup-test.ts | Provide VN to internalKeyFor in fixtures. |
| packages/host/tests/unit/realm-index-card-id-test.ts | Provide VN to index-card helper. |
| packages/host/tests/unit/query-field-normalization-test.ts | Provide VN to normalization + codeRef resolution. |
| packages/host/tests/unit/plan-install-test.ts | Provide VN to catalog install planning utilities. |
| packages/host/tests/unit/index-writer-test.ts | Provide VN to internalKeyFor + createBatch calls. |
| packages/host/tests/unit/index-query-engine-test.ts | Provide VN to internalKeyFor + IndexQueryEngine. |
| packages/host/tests/unit/bfm-card-references-test.ts | Provide VN to BFM reference extraction. |
| packages/host/tests/integration/realm-indexing-test.gts | Use network VN for internalKeyFor assertions. |
| packages/host/tests/helpers/setup-qunit.js | Remove leaked-prefix global-registry diagnostics. |
| packages/host/tests/helpers/indexer.ts | Use loader VN when computing internal keys. |
| packages/host/tests/helpers/index.gts | Rename exported realm constants; pass VN into Loader. |
| packages/host/tests/helpers/adapter.ts | Pass VN into card serialization. |
| packages/host/tests/acceptance/interact-submode-creation-and-permissions-test.gts | Update isLocalId usage to require VN. |
| packages/host/tests/acceptance/commands-test.gts | Pass VN into buildCommandFunctionName. |
| packages/host/tests/acceptance/code-submode/create-file-test.gts | Move prefix mapping registration onto per-test VN. |
| packages/host/tests/acceptance/ai-assistant-test.gts | Update catalog/skills realm exports usage. |
| packages/host/app/utils/card-search/type-filter.ts | Require VN for root/base-filter type keys. |
| packages/host/app/services/store.ts | Remove comments about global fallback; use VN-only canonicalization. |
| packages/host/app/services/spec-panel-service.ts | Inject network; use VN for isLocalId. |
| packages/host/app/services/render-service.ts | Use VN-aware isLocalId for cache keys. |
| packages/host/app/services/recent-cards-service.ts | Inject network; use VN for isLocalId. |
| packages/host/app/services/playground-panel-service.ts | Inject network; use VN for isLocalId. |
| packages/host/app/services/operator-mode-state-service.ts | Use VN-aware isLocalId in multiple flows. |
| packages/host/app/lib/utils.ts | Export catalog/skills realm URLs as strings (not RealmPaths). |
| packages/host/app/lib/gc-card-store.ts | Use VN-aware isLocalId in GC store logic. |
| packages/host/app/lib/file-def-manager.ts | Thread VN into codeRefWithAbsoluteIdentifier. |
| packages/host/app/lib/externals.ts | Register boxel-ui mapping via virtualNetwork.addRealmMapping. |
| packages/host/app/components/operator-mode/interact-submode.gts | Thread VN into codeRefWithAbsoluteIdentifier. |
| packages/host/app/components/operator-mode/create-file-modal.gts | Thread VN into codeRef absolutization. |
| packages/host/app/components/operator-mode/code-submode/spec-preview.gts | Inject network; use VN-aware isLocalId. |
| packages/host/app/components/operator-mode/code-editor.gts | Thread VN into codeRefWithAbsoluteIdentifier. |
| packages/host/app/commands/listing-use.ts | Inject network; thread VN into codeRef resolution. |
| packages/host/app/commands/listing-generate-example.ts | Inject network; pass VN into resolveAdoptsFrom. |
| packages/host/app/commands/generate-theme-example.ts | Plumb network service through generator helper call. |
| packages/host/app/commands/generate-example-cards.ts | Require network for codeRef resolution (VN). |
| packages/host/app/commands/create-specs.ts | Inject network; thread VN into codeRef resolution. |
| packages/experiments-realm/asset.gts | Replace cardIdToURL with virtualNetworkFor URL resolution. |
| packages/experiments-realm/app-card.gts | Guard codeRef absolutization on available VN. |
| packages/base/spec.gts | Remove global resolver usage; guard VN-required operations. |
| packages/base/skill.gts | Require VN for command function-name computation. |
| packages/base/rich-markdown.gts | Pass VN (or fallback VN) into reference extraction. |
| packages/base/query-field-support.ts | Require VN from store; remove global fallbacks. |
| packages/base/menu-items.ts | Guard VN-dependent actions; thread VN into resolution. |
| packages/base/markdown-file-def.gts | Pass VN (or fallback VN) into reference extraction. |
| packages/base/default-templates/markdown.gts | Resolve URLs via VN when present; degrade without globals. |
| packages/base/codemirror-editor.gts | Resolve URLs via VN when present; degrade without globals. |
| packages/base/cards-grid.gts | Require VN for create-card operations using spec refs. |
| packages/base/card-serialization.ts | Degrade serialization without VN; stop using global prefix registry. |
| packages/base/card-api.gts | Replace global resolver fallback with VN or plain URL math. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The two compute blocks read `virtualNetworkFor(this)?.toURL(rel) ?? new URL(rel)` to derive a base URL. In detached / static-parse contexts where `virtualNetworkFor(this)` returns undefined and `rel` is a prefix-form RRI (e.g. `@cardstack/…/Asset/foo`), the `new URL(rel)` fallback throws, crashing the compute. Wrap the base+join in try/catch and return the raw `logoURL` on failure so the `<img src>` binding still has a string to render. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
MarkdownTemplate's resolveUrl helper bailed to the raw ref immediately when called without a VirtualNetwork, dropping URL-form refs and URL-form-base relative-ref resolution that doesn't need a VN to begin with. With a VN we still route through it (so prefix-form bases / registered prefix-form refs round-trip correctly); without one, `new URL(raw, baseUrl)` handles the URL-form cases, and prefix-form bases (which genuinely need a VN) fall through to the raw ref. The host MarkdownField default-template renders supply a baseUrl but no VN today, so this path is reachable from a real caller (the `virtualNetworkFor(card)`-less Field default rendering — see follow-up CS-11375). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The no-VN branch's `new URL(reference, base)` threw for prefix-form references against a non-URL base (or against no base at all), contradicting the comment's degrade-not-throw intent. Wrap so the fallback returns the raw reference unchanged when URL construction fails — callers like LinksTo.deserialize then receive a string they can recognize as unresolved instead of having to handle a TypeError. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Mirror of the fix in default-templates/markdown.gts: when no VN is in scope, the helper bailed straight to the raw ref instead of trying a URL-form join. With a VN we still route through it (so prefix-form bases and registered prefix-form refs round-trip correctly); without one, `new URL(raw, baseUrl)` handles URL-form refs and relative refs against URL-form bases, with the raw ref as the last-ditch fallback when URL construction throws (e.g. prefix-form bases). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…mappings-cs-10752 # Conflicts: # packages/runtime-common/search-utils.ts
This was referenced Jun 4, 2026
habdelra
approved these changes
Jun 5, 2026
backspace
added a commit
that referenced
this pull request
Jun 16, 2026
…sts) The two "indexing identifies an instance's ... references" tests assert the instance's `deps`. Two intended shifts now apply: - base modules serialize as RRI form (`@cardstack/base/X`), not the virtual-alias URL. - boxel-ui deps resolve to the bare prefix (`@cardstack/boxel-ui/X`) because the base-import root change (#5081) registers an `addRealmMapping('@cardstack/boxel-ui/', …)`; boxel-host has no such mapping, so its deps correctly stay `https://packages/@cardstack/boxel-host/…`. Both are intended runtime behavior (no code change); the expectations are regenerated from the runtime's own sorted output. The arrays are compared after `.sort()`, so the re-prefixed entries reorder into the `@`-prefixed group ahead of the `http(s)://` entries. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step toward
@cardstack/base. The former global functions likeregisterCardReferencePrefixandresolveCardReferenceno longer exist, now a virtual network tracks prefix registration and resolves them. Places that don’t have a virtual network either throw, return falsy values, or operate only on URL-flavoured RRIs:NetworkServicemodule-cache-coordination-testWhile some fallback is always needed because a virtual network could be empty of prefix mappings, there are two followup issues to clean some of this up:
MarkdownFieldruntime-common/card-reference-resolverisruntime-common/realm-identifiersnow, since its namesake functions are gone.