CS-11324: upgrade eslint-plugin-ember to ^13.3.2#5088
Merged
Conversation
Bumps the catalog entry and the four workspace packages that directly pin ember-eslint-parser so the install resolves to a single 0.13.0 copy. v13 ships major lint-time performance improvements over v12. Regenerates patches/ember-eslint-parser.patch against the new ESM form of src/preprocessor/noop.js; the intent (mark the misconfig message fatal so CI notices broken gjs/gts linting) is unchanged. Removes two now-redundant `eslint-disable ember/no-test-import-export` directives in @cardstack/host that v13 no longer flags. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the repo’s Ember lint tooling to eslint-plugin-ember@^13.3.2 (for v13 performance work) and aligns ember-eslint-parser across the workspace to ^0.13.0, including updating the local pnpm patch so misconfigured Gjs/Gts linting fails CI as a fatal error.
Changes:
- Bump
eslint-plugin-emberfrom^12.5.0to^13.3.2in the workspace catalog and lockfile. - Align direct
ember-eslint-parserpins across multiple workspace packages to^0.13.0, updating the lockfile accordingly. - Refresh
patches/ember-eslint-parser.patchfor the new ESMnoop.jsimplementation and remove now-unnecessaryember/no-test-import-exportdisables in host tests.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates the workspace catalog to eslint-plugin-ember@^13.3.2 and keeps pnpm overrides/patch config consistent. |
| pnpm-lock.yaml | Locks the new eslint-plugin-ember/ember-eslint-parser versions and associated transitive dependency graph changes. |
| patches/ember-eslint-parser.patch | Updates the patch hunk to match the parser’s newer ESM postprocess implementation and still forces fatal = true. |
| packages/runtime-common/package.json | Updates the directly pinned ember-eslint-parser version range to ^0.13.0. |
| packages/realm-server/package.json | Updates the directly pinned ember-eslint-parser version range to ^0.13.0. |
| packages/eslint-plugin-boxel/package.json | Updates the plugin’s parser dependency to ^0.13.0 to match eslint-plugin-ember@13 expectations. |
| packages/catalog/package.json | Updates the directly pinned ember-eslint-parser version range to ^0.13.0. |
| packages/host/tests/unit/queue-test.ts | Removes a now-redundant eslint-disable for ember/no-test-import-export. |
| packages/host/tests/live-test.js | Removes a now-redundant eslint-disable for ember/no-test-import-export. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
re speeds, comparing to the latest run on #5073:
I don’t know that it’s definitely faster (or slower), but that doesn’t mean we shouldn’t update! |
backspace
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-plugin-embercatalog from^12.5.0to^13.3.2for the major lint-time performance work landed in v13.ember-eslint-parser(catalog,realm-server,runtime-common,eslint-plugin-boxel) from0.5.9to^0.13.0, so the install resolves to a single parser copy that matches whateslint-plugin-ember@13wants.patches/ember-eslint-parser.patchagainst the new ESM form ofsrc/preprocessor/noop.js(same intent — mark the gjs/gts misconfig messagefatalso CI notices).eslint-disable ember/no-test-import-exportdirectives in@cardstack/hosttests that v13 no longer flags.Linear: CS-11324
Why now
v13 dropped support for ESLint < 8.40 (we're on
^8.57.1, fine) and Node < 20.19 (we're on Node 22/24, fine). The CJSrequire('ember-eslint-parser')calls inpackages/eslint-plugin-boxelcontinue to work via Node's unflaggedrequire(esm)support —noop.jsand the parser entry have no top-level await.Test plan
pnpm installresolves cleanly (single version ofeslint-plugin-ember@13.3.2andember-eslint-parser@0.13.0)pnpm --filter @cardstack/host lint(lint:js, lint:hbs, lint:types)pnpm --filter @cardstack/boxel-ui lintpnpm --filter @cardstack/boxel-icons lintpnpm --filter @cardstack/catalog lintpnpm --filter test-app lintpnpm --filter @cardstack/runtime-common lintpnpm --filter @cardstack/realm-server lintpnpm --filter @cardstack/eslint-plugin-boxel lintpackages/hostbefore/after to confirm the perf win🤖 Generated with Claude Code