Skip to content

Sync the card-chooser selection ring with the tag (CS-11330)#5118

Merged
lukemelia merged 1 commit into
mainfrom
cs-11330-transition-sync
Jun 5, 2026
Merged

Sync the card-chooser selection ring with the tag (CS-11330)#5118
lukemelia merged 1 commit into
mainfrom
cs-11330-transition-sync

Conversation

@lukemelia

Copy link
Copy Markdown
Contributor

Resolves CS-11330. Split out of #5111.

The selected ring faded in over box-shadow 0.2s while the selection tag/chip render instantly, so the border appeared ~0.2s after the tag.

Fix: transition: none on the selected ring — including the :hover variant, since a card is normally hovered at the moment it's clicked to select, so that rule governs the ring's first paint — so the ring and tag appear together.

⚠️ Stacked on #5117 (base branch cs-11329-selection-ring). Review/merge after #5117; the diff here is only the transition change.

🤖 Generated with Claude Code

…CS-11330)

The selected ring faded in over `box-shadow 0.2s` while the selection
tag/chip render instantly, so the border appeared ~0.2s after the tag.
Set `transition: none` on the selected ring so the two appear together.
The `:hover` variant needs it too: a card is normally hovered at the
moment it's clicked to select, so that rule governs the ring's first
paint — without it the ring still animated in late on select-while-hovered.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Preview deployments

Host Test Results

    1 files      1 suites   1h 47m 39s ⏱️
2 936 tests 2 921 ✅ 15 💤 0 ❌
2 955 runs  2 940 ✅ 15 💤 0 ❌

Results for commit abe98a1.

Realm Server Test Results

    1 files      1 suites   13m 41s ⏱️
1 559 tests 1 558 ✅ 1 💤 0 ❌
1 650 runs  1 649 ✅ 1 💤 0 ❌

Results for commit abe98a1.

@lukemelia lukemelia marked this pull request as ready for review June 5, 2026 04:10
@lukemelia lukemelia requested review from a team and burieberry June 5, 2026 04:10
@lukemelia lukemelia changed the base branch from cs-11329-selection-ring to main June 5, 2026 20:24
@lukemelia lukemelia merged commit b9fae2c into main Jun 5, 2026
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants