Sync the card-chooser selection ring with the tag (CS-11330)#5118
Merged
Conversation
…CS-11330) The selected ring faded in over `box-shadow 0.2s` while the selection tag/chip render instantly, so the border appeared ~0.2s after the tag. Set `transition: none` on the selected ring so the two appear together. The `:hover` variant needs it too: a card is normally hovered at the moment it's clicked to select, so that rule governs the ring's first paint — without it the ring still animated in late on select-while-hovered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
jurgenwerk
approved these changes
Jun 5, 2026
burieberry
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CS-11330. Split out of #5111.
The selected ring faded in over
box-shadow 0.2swhile the selection tag/chip render instantly, so the border appeared ~0.2s after the tag.Fix:
transition: noneon the selected ring — including the:hovervariant, since a card is normally hovered at the moment it's clicked to select, so that rule governs the ring's first paint — so the ring and tag appear together.cs-11329-selection-ring). Review/merge after #5117; the diff here is only the transition change.🤖 Generated with Claude Code