Skip to content

Sync the card-chooser selection ring with the tag (CS-11330) #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukemelia merged 1 commit into from
Jun 5, 2026
Merged

Sync the card-chooser selection ring with the tag (CS-11330) #5118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/host/app/components/card-search/item-button.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,15 @@ export default class ItemButton extends Component<Signature> {
which the portaled catalog item didn't reliably inherit — leaving
only the thin 1px button border) so the ring stays a full-weight
4px whether or not the item is hovered, darkening on hover to match
the rest of the Adorn treatment. */
.catalog-item.adorn.selected {
the rest of the Adorn treatment. `transition: none` makes the ring
appear in lockstep with the selection tag/chip (which render
instantly) instead of fading in ~0.2s later — and it's needed on the
hover variant too, since a card is normally hovered at the moment
it's clicked to select, so that rule governs the ring's first paint. */
.catalog-item.adorn.selected,
.catalog-item.adorn.selected:hover {
box-shadow: 0 0 0 0.25rem var(--boxel-highlight);
transition: none;
}
.catalog-item.adorn.selected:hover {
box-shadow: 0 0 0 0.25rem var(--boxel-highlight-hover);
Expand Down
Loading