Skip to content

Rename the legacy catalog-item CSS class to item-button#5119

Merged
lukemelia merged 1 commit into
mainfrom
rename-catalog-item-to-item-button
Jun 5, 2026
Merged

Rename the legacy catalog-item CSS class to item-button#5119
lukemelia merged 1 commit into
mainfrom
rename-catalog-item-to-item-button

Conversation

@lukemelia

Copy link
Copy Markdown
Contributor

Split out of #5111.

Renames the legacy catalog-item CSS class (and its test selectors) to item-button, aligning the class with the ItemButton component name. Pure rename — no behavior change.

⚠️ Stacked on #5118 (base branch cs-11330-transition-sync), since it renames the selectors that #5117/#5118 add. Review/merge last; the diff here is only the rename.

🤖 Generated with Claude Code

The styling class on this component predated its rename to `ItemButton`;
`catalog-item` also mis-implied it's catalog-only when it also renders search
results. Rename the scoped class (and the `.catalog-item` test assertions) to
match the component. The separate `data-test-card-catalog-item` attributes are
left as-is.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Preview deployments

Host Test Results

    1 files      1 suites   1h 52m 5s ⏱️
2 936 tests 2 921 ✅ 15 💤 0 ❌
2 955 runs  2 940 ✅ 15 💤 0 ❌

Results for commit 5f3cf19.

Realm Server Test Results

    1 files      1 suites   12m 42s ⏱️
1 559 tests 1 558 ✅ 1 💤 0 ❌
1 650 runs  1 649 ✅ 1 💤 0 ❌

Results for commit 5f3cf19.

@lukemelia lukemelia requested review from a team and FadhlanR June 5, 2026 02:38
@lukemelia lukemelia marked this pull request as ready for review June 5, 2026 02:38
@lukemelia lukemelia changed the base branch from cs-11330-transition-sync to main June 5, 2026 20:25
@lukemelia lukemelia merged commit 1e9229c into main Jun 5, 2026
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants