Remove the Adorn label grey peek and sit it flush below the card (CS-11331)#5120
Merged
Conversation
When the type-label tab flips below a card (no room above), it overlapped the card's bottom edge by 2px, leaving it sitting one pixel too high over the edge. Reduce the overlap to 1px so the flag's top edge still tucks under the bottom outline stroke and reads as attached. Addresses the vertical-alignment point of CS-11331; verified live (overlap 2px → 1px). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Adorn label tab cast a grey `drop-shadow` filter that bled out past its clipped/rounded corners as a grey peek. Remove it. Combined with the 1px below-card nudge, the tab reads as cleanly attached to the card. Two of the three CS-11331 points are addressed here (grey peek and the below-card vertical alignment). The border-radius point is left as a deliberate design call — the tab is a separate 24px-tall flag and the card is 10px, so force-matching the radii would make the small tab look disproportionate — and CS-11331 stays open for it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Preview deploymentsHost Test Results 1 files ±0 1 suites ±0 1h 52m 12s ⏱️ + 14m 2s Results for commit 7893dec. ± Comparison against earlier commit 7d7b880. Realm Server Test Results 1 files ±0 1 suites ±0 11m 7s ⏱️ - 1m 57s Results for commit 7893dec. ± Comparison against earlier commit 7d7b880. |
A 1px overlap into the card still read as the tag riding slightly too high. Anchor the flipped-below label's top edge exactly at the card's bottom edge (zero overlap) instead; its z-index keeps it above the selection outline stroke, so it still reads as attached. Verified live (label top == card bottom). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lukemelia
changed the title
jurgenwerk
approved these changes
Jun 5, 2026
burieberry
approved these changes
Jun 5, 2026
burieberry
left a comment
burieberry
left a comment
Contributor
There was a problem hiding this comment.
border radii are fine with me as long as they're matching those of the design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CS-11331 (2 of 3 points). Split out of #5111.
drop-shadowfilter that bled past its clipped/rounded corners; removed it.Base:
main— independent of theitem-buttonring stack (#5117 → #5118 → #5119), so it can land on its own.🤖 Generated with Claude Code