feat(acp): add config option settings modal by carlos-algms · Pull Request #276 · carlos-algms/agentic.nvim

carlos-algms · 2026-07-13T21:07:03Z

retain every ACP config option
support boolean config updates
add session-safe settings modal
expose configurable widget keymap
document and test new workflow
validate live provider interactions

- verify live select and boolean changes - verify modal remains open - verify stale session rejection

coderabbitai · 2026-07-13T21:07:11Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 963b0bf1-cbf1-4a98-bfb6-44061ccc410a

📥 Commits

Reviewing files that changed from the base of the PR and between 2400c6f and 543bb35.

📒 Files selected for processing (2)

lua/agentic/ui/config_options_modal.lua
lua/agentic/ui/config_options_modal.test.lua

📝 Walkthrough

Walkthrough

Adds ACP session configuration capabilities and boolean option types alongside selectable options. The client uses a parameter-table API for setting options. AgentConfigOptions stores and snapshots all options, routes changes through unified handling, and preserves legacy callbacks. A floating options modal supports boolean toggles, selectors, navigation, session checks, and re-rendering. The widget adds <localLeader>o to open the modal, with updated defaults and documentation.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Modal as ConfigOptionsModal
  participant Config as AgentConfigOptions
  participant ACP as ACPClient
  User->>Modal: Activate option
  Modal->>Config: handle_change(configId, value, on_done)
  Config->>ACP: set_config_option(params, callback)
  ACP-->>Config: Return configOptions
  Config->>Config: Apply options and invoke callbacks
  Config-->>Modal: Confirm change
  Modal->>Modal: Schedule re-render

Possibly related PRs

carlos-algms/agentic.nvim#269: Refactors configuration-option change handling extended by this PR.
carlos-algms/agentic.nvim#209: Modifies thought-level configuration handling integrated into the unified dispatch.
carlos-algms/agentic.nvim#144: Introduces ACP config-option plumbing extended by this PR.

Poem

A rabbit taps <localLeader>o with glee,
A settings modal blooms by the tree.
Boolean switches hop and glow,
Selectors guide the values’ flow,
ACP carries each choice away. 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: adding a config option settings modal.
Description check	✅ Passed	The description is clearly related to the changeset and covers the new modal, boolean updates, keymap, docs, tests, and provider validation.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/acp-config-settings-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lua/agentic/acp/agent_config_options.lua`:
- Around line 596-615: Update the asynchronous option-change handlers around
_make_change_response to capture the initiating option ID and generation, track
the latest request per ID, and re-resolve the current target before applying
success or selector results. Ignore stale responses, prevent old values from
being applied to replaced options or newer choices, and guard against nil
targets when IDs change. Add regression coverage for both the in-flight request
race and selector race.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 650c793d-def0-4fd3-ae09-a4245adae79e

📥 Commits

Reviewing files that changed from the base of the PR and between a37f19f and 1b0c0e6.

📒 Files selected for processing (12)

README.md
doc/agentic.txt
lua/agentic/acp/acp_client.lua
lua/agentic/acp/acp_client.test.lua
lua/agentic/acp/acp_client_types.lua
lua/agentic/acp/agent_config_options.lua
lua/agentic/acp/agent_config_options.test.lua
lua/agentic/config_default.lua
lua/agentic/config_selector.test.lua
lua/agentic/session_manager.lua
lua/agentic/ui/config_options_modal.lua
lua/agentic/ui/config_options_modal.test.lua

…ngs-modal

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lua/agentic/ui/config_options_modal.lua`:
- Around line 128-130: Update the modal sizing logic near build_lines and height
so width is at least the maximum rendered line width, while retaining the
existing vim.o.columns percentage as the default sizing basis. Compute the
longest entry in lines and use that value as a lower bound for width, ensuring
long configuration values do not wrap or exceed the modal height.
- Around line 219-228: Update the navigation logic around _option_rows and
cursor_row so non-option cursor positions search explicitly for the nearest
option row in the requested direction before calculating target. Preserve direct
index handling when cursor_row is an option, and ensure j/k choose the
next/previous option rather than defaulting current to 1.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a0c67035-bbe1-4e90-a4c4-86a94e1263db

📥 Commits

Reviewing files that changed from the base of the PR and between bda0a4e and 064c7c6.

📒 Files selected for processing (2)

lua/agentic/ui/config_options_modal.lua
lua/agentic/ui/config_options_modal.test.lua

carlos-algms added 12 commits July 13, 2026 20:36

Add types for boolean config options and boolean capability

16ed912

Correct config option union ingress types

ace4237

Advertise boolean session config option capability

a50c628

Send boolean variant from set_config_option

a86a721

Retain all config options in an ordered list

0c6f89b

Correct ordered option ingress annotations

a42cd53

Add generic config option change handler

952c538

Add settings modal floating window

3d1b573

Guard select dispatch after session changes

c7a9971

Add settings modal keymap and docs

c733305

- verify live select and boolean changes - verify modal remains open - verify stale session rejection

Expose config option selector

40266cc

Cover unknown config option logging

4e6d033

carlos-algms commented Jul 14, 2026

View reviewed changes

carlos-algms added 2 commits July 14, 2026 22:29

Simplify config option APIs and modal coupling

c20fbeb

Prefix select values with dropdown icon

1b0c0e6

carlos-algms marked this pull request as ready for review July 14, 2026 20:51

coderabbitai Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread lua/agentic/acp/agent_config_options.lua

carlos-algms added 3 commits July 15, 2026 14:57

Notify when a select option has no values

bda0a4e

Merge remote-tracking branch 'origin/main' into feat/acp-config-setti…

10623ab

…ngs-modal

Format settings modal rows with descriptions and j/k nav

064c7c6

coderabbitai Bot reviewed Jul 19, 2026

View reviewed changes

Comment thread lua/agentic/ui/config_options_modal.lua

Comment thread lua/agentic/ui/config_options_modal.lua Outdated

carlos-algms added 2 commits July 19, 2026 16:47

Rename settings modal to options across code and docs

2400c6f

Pick nearest option row for j/k from non-option rows

543bb35

carlos-algms merged commit 246feb4 into main Jul 19, 2026
10 checks passed

carlos-algms deleted the feat/acp-config-settings-modal branch July 19, 2026 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(acp): add config option settings modal#276

feat(acp): add config option settings modal#276
carlos-algms merged 19 commits into
mainfrom
feat/acp-config-settings-modal

carlos-algms commented Jul 13, 2026

Uh oh!

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

Reviews paused

Walkthrough

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

carlos-algms commented Jul 13, 2026

Uh oh!

coderabbitai Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading