-
-
Notifications
You must be signed in to change notification settings - Fork 53
feat(acp): add config option settings modal #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
16ed912
Add types for boolean config options and boolean capability
carlos-algms ace4237
Correct config option union ingress types
carlos-algms a50c628
Advertise boolean session config option capability
carlos-algms a86a721
Send boolean variant from set_config_option
carlos-algms 0c6f89b
Retain all config options in an ordered list
carlos-algms a42cd53
Correct ordered option ingress annotations
carlos-algms 952c538
Add generic config option change handler
carlos-algms 3d1b573
Add settings modal floating window
carlos-algms c7a9971
Guard select dispatch after session changes
carlos-algms c733305
Add settings modal keymap and docs
carlos-algms 40266cc
Expose config option selector
carlos-algms 4e6d033
Cover unknown config option logging
carlos-algms c20fbeb
Simplify config option APIs and modal coupling
carlos-algms 1b0c0e6
Prefix select values with dropdown icon
carlos-algms bda0a4e
Notify when a select option has no values
carlos-algms 10623ab
Merge remote-tracking branch 'origin/main' into feat/acp-config-setti…
carlos-algms 064c7c6
Format settings modal rows with descriptions and j/k nav
carlos-algms 2400c6f
Rename settings modal to options across code and docs
carlos-algms 543bb35
Pick nearest option row for j/k from non-option rows
carlos-algms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.