Skip to content

HTTPS applink support for iOS and Android first try - #603

Open
jakdan99 wants to merge 1 commit into
testfrom
panosfunk-install-app-on-qr-scan
Open

HTTPS applink support for iOS and Android first try#603
jakdan99 wants to merge 1 commit into
testfrom
panosfunk-install-app-on-qr-scan

Conversation

@jakdan99

@jakdan99 jakdan99 commented Jun 9, 2026

Copy link
Copy Markdown

specifying deep link paths to allow for anonymous auth in android at the same time

specifying deep link paths to allow for anonymous auth in android at the same time

specifying deep link paths to allow for anonymous auth in android at the same time

works for the most part

it works

removing prints

Merge fixes
@jakdan99
jakdan99 requested a review from Zeroupper June 9, 2026 10:50
@Zeroupper

Copy link
Copy Markdown
Collaborator

@jakdan99 just saw this. What is this for?

@Zeroupper Zeroupper left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions, we can also discuss tomorrow. @jakdan99

Comment thread pubspec.yaml
Comment on lines +96 to +97
carp_webservices:
path: ../carp.sensing-flutter/backends/carp_webservices/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local path stayed in

});

final qrcode = scanData.code;
print('QR code scanned: $qrcode');

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print

child: TextButton(
onPressed: () async {
bool isConnected = await bloc.checkConnectivity();
print("isConnected: $isConnected");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print

Comment on lines -120 to +123
info('$runtimeType - ANONYMOUS User authenticated - user: $user');
print('$runtimeType - ANONYMOUS User authenticated - user: $user');

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why changed to print

Comment on lines +7 to +9
<string>applinks:study.app.dev.carp.dk</string>
<string>applinks:study.app.test.carp.dk</string>
<string>applinks:study.app.carp.computerome.dk</string>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is prod fro carp.dk

<Scheme
LastUpgradeVersion = "1510"
version = "1.3">
version = "1.7">

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this version upgrade for?

Comment on lines +94 to +100
<EnvironmentVariables>
<EnvironmentVariable
key = "DART_DEFINES"
value = "ZGVwbG95bWVudC1tb2RlPWRldg=="
isEnabled = "YES">
</EnvironmentVariable>
</EnvironmentVariables>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs explanation, dart define should be part of the build parameters or what is this for?

Comment on lines +47 to +48
<!--Location
Permissions-->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this got into 2 lines?

Comment on lines +53 to +54
<!--Foreground
Service Permissions for Android >= 14 / SDK 34-->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this got into 2 lines?

Comment on lines -124 to -131
<data android:scheme="carp-ws-prod-auth" android:host="auth" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not used by anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants